Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metadata.appintentsforCodexBarWidgetduring packaging so the widget extension ships the App Intents metadata WidgetKit expects@Parameter(default:)for Codex / Credits defaults instead of optional fallback helpersWhy
This supersedes #782 while preserving the original fix from @vincentyangch.
The packaging issue is real: the packaged widget extension was shipping without
Resources/Metadata.appintents, and this branch keeps that fix. The follow-up cleanup keeps the App Intent model aligned with Apple's documented widget configuration style by using non-optional parameters with defaults rather than optional parameters plus runtime fallback helpers.Details
ab904049from @vincentyangch for widget metadata generation and packaging7d9d440bto replace optional widget configuration parameters with@Parameter(default:)resolvedWidgetProvider/resolvedCompactMetrichelpersValidation
swift test -q --filter CodexBarWidgetProviderTestspnpm check./Scripts/compile_and_run.shMetadata.appintents/version.jsonMetadata.appintents/extract.actionsdataCredit
Original packaging fix by @vincentyangch in #782; this PR carries that change forward with a small follow-up cleanup.