Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a343e51ba2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !self.hasInstalledWeeklyLimitResetObserver { | ||
| NotificationCenter.default.addObserver( | ||
| self, | ||
| selector: #selector(self.handleWeeklyLimitResetNotification(_:)), | ||
| name: .codexbarWeeklyLimitReset, | ||
| object: nil) | ||
| self.hasInstalledWeeklyLimitResetObserver = true |
There was a problem hiding this comment.
Move this observer setup earlier in startup: UsageStore kicks off Task { await self.refresh() } during initialization (Sources/CodexBar/UsageStore.swift), which can post .codexbarWeeklyLimitReset before applicationDidFinishLaunching runs. On a cold launch right after a weekly reset, that first notification is dropped and the confetti event never appears even though the detector fired.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
is P2 all you got?!
also how can it post notif before applicationDidFinishLaunching 😱
|
@zats Please help fix the failing CI checks. |
zats
force-pushed
the
weekly-limit-confetti-clean
branch
from
a343e51 to
7f5c4b3
Compare
|
@ratulsarna flag is for the number of lines in tests; took liberty to add lint ignores - breaking tests into extensions just makes it less readable, lmk |
|
I believe lint is passing now but there is a build error. |
|
True but I am not sure if I can fix github 😅 |
|
Ran them again :) |
|
thank you! looks like it keeps failing on the same github access when checking out packages if I read the logs right |
|
This is what codex is saying : 
Could this be the issue? I haven't dug in yet. |
zats
force-pushed
the
weekly-limit-confetti-clean
branch
from
7f5c4b3 to
ad8b15e
Compare
|
good eye! I think should be fixed now (opened a pr upstream switched to local dep in the meantime) P.S. seems like CI has to be triggered by maintainer |
|
Thanks for the contribution @zats and thanks for working through it with me! |
|
Thank you for your patience :)
…On Fri, Apr 24, 2026 at 5:38 AM ratulsarna ***@***.***> wrote:
*ratulsarna* left a comment (steipete/CodexBar#785)
<#785 (comment)>
Thanks for the contribution @zats <https://github.com/zats> and thanks
for working through it with me!
—
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUQOJXL47N2SGYON4OWIC34XMYX3AVCNFSM6AAAAACYCT57DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMJSGE2DAMZTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
2 participants
Bringing some joy for the weekly limits reset with opt-in confetti setting
Screen.Recording.2026-04-21.at.6.20.59.PM.2.mp4
TLDR is every time we fetch usage we compare was the previous weekly usage was > 1% and new is ≤ 1% - if condition is met we fire confetti