Rename Codex Pro Lite/Pro to official name Pro 5x/Pro 20x#882
Rename Codex Pro Lite/Pro to official name Pro 5x/Pro 20x#882steipete merged 2 commits intosteipete:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Codex plan naming to match the official usage-multiplier branding (“Pro 5x” / “Pro 20x”) and ensures this formatting is applied only for the Codex provider in UI/menu rendering.
Changes:
- Update Codex plan display-name mapping:
pro → Pro 20x,prolite/pro_lite/pro-lite/pro lite → Pro 5x. - Scope Codex-specific plan formatting to
.codexprovider in menu and menu card rendering to avoid affecting other providers. - Update snapshots/characterization/unit tests to assert the new plan names and ensure old strings no longer appear.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/CodexBarTests/OpenAIDashboardParserTests.swift | Updates expected parsed plan label for prolite to “Pro 5x”. |
| Tests/CodexBarTests/CodexPresentationCharacterizationTests.swift | Updates menu rendering expectations to “Pro 5x” and asserts legacy strings are absent. |
| Tests/CodexBarTests/CodexPlanFormattingTests.swift | Expands test coverage for pro/prolite aliases mapping to “Pro 20x” / “Pro 5x”. |
| Tests/CodexBarTests/CLISnapshotTests.swift | Updates CLI output expectations for Codex plan labels to multiplier names. |
| Sources/CodexBarCore/Providers/Codex/CodexPlanFormatting.swift | Implements the new multiplier display-name mapping and centralizes exact-match handling early in formatting. |
| Sources/CodexBar/MenuDescriptor.swift | Makes plan formatting provider-aware so only Codex gets Codex plan mapping. |
| Sources/CodexBar/MenuCardView.swift | Makes plan formatting provider-aware for the menu card view model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
steipete
force-pushed
the
codex/update-codex-plan-labels
branch
from
b6b3106 to
b0f1f0e
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0f1f0e810
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let exact = Self.exactDisplayNames[candidate.lowercased()] { | ||
| return exact | ||
| } |
There was a problem hiding this comment.
The new exact-match check only compares the whole cleaned candidate, so plan IDs that still carry separators after boilerplate stripping (for example codex_prolite or codex_pro) no longer hit the prolite/pro mapping and fall through to generic capitalization (Prolite/Pro) instead of Pro 5x/Pro 20x. This is a regression from the previous per-token mapping behavior and can leak inconsistent plan labels in menu/CLI output when upstream returns prefixed tier identifiers.
Useful? React with 👍 / 👎.
steipete
left a comment
steipete
left a comment
There was a problem hiding this comment.
Looks good. Verified the Codex-only plan-label path and CLI snapshot coverage locally; added the changelog note. CI green.
Self explanatory.