[codex] reduce keychain prompt churn during dev runs#888
Merged
ngutman merged 1 commit intosteipete:mainfrom May 10, 2026
Merged
[codex] reduce keychain prompt churn during dev runs#888ngutman merged 1 commit intosteipete:mainfrom
ngutman merged 1 commit intosteipete:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Reduce repeated macOS Keychain prompts during local CodexBar development runs.
Two prompt sources were addressed:
compile_and_run.shcould fall back to ad-hoc signing even when the developer had a valid local signing identity. Ad-hoc signing changes the app identity across rebuilds, which makes Keychain approvals unstable.KeychainCacheStore.storetried to rewrite theCodexBar Cacheitem ACL on every cache update. UpdatingkSecAttrAccesscan trigger the "change the owner" login keychain prompt even when CodexBar only needs to refresh cached data.Changes
Scripts/compile_and_run.shbefore falling back to ad-hoc signing.APP_TEAM_IDfrom the detected identity when possible, while preserving explicitAPP_IDENTITY/APP_TEAM_IDoverrides and Peter's existing preferred identity path.KeychainCacheStoreentries by writing onlykSecValueData.CodexBar Cacheentries.Verified behavior
Developer ID Application: Nimrod Gutman (GZS353X62E)KeychainCacheStorestill stores, overwrites, loads, clears, and lists cache entries through the focused test suite.CODEXBAR_ALLOW_MISSING_WIDGET_METADATA=1; the script reportedOK: CodexBar is running.Validation
swift test --filter KeychainCacheStoreTestsmake checkCODEXBAR_ALLOW_MISSING_WIDGET_METADATA=1 ./Scripts/compile_and_run.sh --waitNotes
Existing cache items with stale ACLs are no longer repaired during routine cache refreshes. That is intentional: the ACL repair attempt was the prompt trigger, and these entries are caches. If a local cache item is already in a bad state, deleting the
com.steipete.codexbar.cachegeneric-password items lets CodexBar recreate them with the current ACL.