Skip to content

Fix z.ai MCP monthly window label#904

Merged
steipete merged 2 commits into
steipete:mainfrom
ThiagoCAltoe:fix-zai-mcp-monthly-window
May 11, 2026
Merged

Fix z.ai MCP monthly window label#904
steipete merged 2 commits into
steipete:mainfrom
ThiagoCAltoe:fix-zai-mcp-monthly-window

Conversation

@ThiagoCAltoe
Copy link
Copy Markdown
Contributor

Summary

  • show z.ai MCP TIME_LIMIT usage as Monthly instead of the raw 1 minute window API label
  • keep token limit window labels unchanged
  • add regression coverage for the z.ai MCP monthly label

Fixes #115.

Validation

  • git diff --check
  • Swift tests not run locally (Swift toolchain is not installed on this Raspberry Pi). GitHub CI will validate.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2816e82bf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 200 to 201
if limit.type == .timeLimit {
return "Monthly"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep non-MCP time-window labels

When a z.ai TIME_LIMIT is anything other than the MCP 1-minute marker, this now still reports Monthly; for example the existing maps usage snapshot windows test builds a 30-day TIME_LIMIT and expects 30 days window, so the suite will fail and real non-1-minute time limits lose their accurate label. Gate the override to the specific MCP/monthly case instead of applying it to every .timeLimit.

Useful? React with 👍 / 👎.

@ThiagoCAltoe ThiagoCAltoe force-pushed the fix-zai-mcp-monthly-window branch 4 times, most recently from 96bb50d to 33669bc Compare May 11, 2026 06:59
@ThiagoCAltoe ThiagoCAltoe force-pushed the fix-zai-mcp-monthly-window branch from 33669bc to 3fae9ce Compare May 11, 2026 08:07
@steipete steipete merged commit 3356090 into steipete:main May 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

z.ai mcp "1 minute window"

2 participants