fix: afix: add Windows timezone support for IANA timezone namesdd Windows timezone support for IANA timezone names#118
Open
wirihere wants to merge 1 commit intosteipete:mainfrom
Open
Conversation
On Windows, time.LoadLocation() fails to recognize IANA timezone names like "Pacific/Auckland" because Windows uses a different timezone database. This commit adds a fallback mechanism that maps common IANA timezone names to their UTC offsets. Changes: - Add timezone_windows.go with IANA to UTC offset mapping - Update all time.LoadLocation calls to use loadLocationWithFallback - Add loadLocationWithFallback to config package for validation - Supports Pacific/Auckland (+13:00) and other common timezones Fixes the issue where gogcli calendar commands failed on Windows with "unknown time zone" errors for IANA timezone names. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, time.LoadLocation() fails to recognize IANA timezone names like "Pacific/Auckland" because Windows uses a different timezone database. This commit adds a fallback mechanism that maps common IANA timezone names to their UTC offsets.
Changes:
Fixes the issue where gogcli calendar commands failed on Windows with "unknown time zone" errors for IANA timezone names.