contacts: support --birthday and --notes in contacts update#233
Merged
steipete merged 2 commits intosteipete:mainfrom Feb 13, 2026
Merged
contacts: support --birthday and --notes in contacts update#233steipete merged 2 commits intosteipete:mainfrom
steipete merged 2 commits intosteipete:mainfrom
Conversation
bcd0e40 to
82905bc
Compare
Owner
|
Landed via temp rebase onto main.
Thanks @rosssivertsen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
gog contacts updateto support updating two additional People API fields that users commonly need but that weren't previously exposed:--birthday YYYY-MM-DD(writes People APIbirthdays, primary)--notes <text>(writes People APIbiographies, primary;TEXT_PLAIN)Both flags support clearing by passing an empty string.
Implementation details:
birthdays,biographiesincluded in the PersonFields mask when running update.UpdatePersonFieldsentries (birthdays,biographies).YYYY-MM-DD).Motivation: we hit this gap while automating contact hygiene, and the underlying People API supports these fields; it's mainly a CLI UX/coverage gap.
Testing:
go test ./...passes in a clean env.