fix(generate-cli): use camelCase for Commander.js option names#28
Merged
steipete merged 1 commit intosteipete:mainfrom Dec 29, 2025
Merged
Conversation
Commander.js converts kebab-case flag names (e.g., --relative-path) to camelCase property names (e.g., relativePath) when accessing cmdOpts. The generated CLI template was using the original property names from the schema (often snake_case), causing option values to not be recognized. This converts the CLI option name to camelCase when generating cmdOpts property access.
Owner
|
Thanks! Taking over. |
Owner
|
Thanks for the fix, @rawwerks! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generated CLIs fail to recognize option values when the MCP server uses snake_case property names in its schema.
For example, when a tool has a property
relative_path, the generated CLI creates:--relative-pathcmdOpts.relative_pathBut Commander.js converts
--relative-pathtorelativePath(camelCase), so the option value is never read.Solution
Convert the CLI option name to camelCase when generating the
cmdOptsproperty access, matching Commander.js's behavior.Testing
Tested with an MCP server that uses snake_case properties - options now work correctly.