Fix ChatGPT composer-pill DOM rewrite (model + thinking-effort) by SyntaxSmith · Pull Request #146 · steipete/oracle

SyntaxSmith · 2026-04-30T02:54:04Z

Summary

Restores browser mode after ChatGPT's recent composer rewrite:

The model picker dropped `data-testid="model-switcher-dropdown-button"` in favor of a `__composer-pill` button. `MODEL_BUTTON_SELECTOR` now matches both the legacy testid and the new pill so existing accounts and the rewritten composer both work.
The standalone "Thinking" composer chip is gone; effort is now a per-row trailing button inside the model menu (`[data-model-picker-thinking-effort-action="true"]`). `buildThinkingTimeExpression` opens the model menu, picks the trailing button for the selected row, resolves the submenu via `aria-controls`, and selects the matching effort, with bilingual EN/中文 label matching for users on Chinese ChatGPT. The old composer-chip flow stays as a fallback.
`ensureThinkingTime` now logs a debug DOM dump and returns on any not-found state instead of throwing. With ChatGPT's UI churning, the safer default is to keep Pro consults alive on whatever effort the UI defaults to rather than fail the run.

Without this, every browser-mode consult fails at "Unable to locate the ChatGPT model selector button" (or, after working around that, at "Unable to find the Thinking chip button in the composer area").

Test plan

`pnpm build`
`pnpm lint` (typecheck + oxlint, 0 errors)
`pnpm test` (620 passed / 41 skipped)
Live ChatGPT browser smoke against `gpt-5.4-pro` via `oracle serve` + MCP `consult`: returned answer in 44.9s, no errors thrown by model picker or thinking-time selection.

ChatGPT replaced the composer's model picker and thinking-effort chip with a pair of __composer-pill buttons, and the per-effort selector moved into a per-row trailing button inside the model menu. - Extend MODEL_BUTTON_SELECTOR with a fallback for the new pill so model selection works on both the legacy testid and the rewritten composer. - Rewrite buildThinkingTimeExpression to navigate the new data-model-picker-thinking-effort-action trailing button (resolving the submenu via aria-controls) and match effort labels in both English and Chinese, with the old composer-chip flow kept as a fallback for accounts still on the previous UI. - Downgrade ensureThinkingTime to log a debug DOM dump and return on any not-found state instead of throwing, so Pro consults survive further UI shifts on whatever effort ChatGPT defaults to.

Copilot

Pull request overview

Updates the browser automation selectors/flows to keep ChatGPT “browser mode” working after the April 2026 composer DOM rewrite, specifically around model selection and “Thinking effort” selection.

Changes:

Expand the model picker button selector to match both the legacy data-testid button and the new __composer-pill button.
Rework thinking-effort selection to navigate the new model-menu “trailing effort” button (with EN/中文 label token matching) while retaining the legacy chip flow as a fallback.
Change ensureThinkingTime to log debug context and continue with ChatGPT defaults instead of throwing on missing UI elements.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/browser/constants.ts	Broadens the model button selector to include the new composer pill.
src/browser/actions/thinkingTime.ts	Implements new thinking-effort selection path via model menu + adds best-effort non-throwing behavior.
CHANGELOG.md	Documents the browser automation fix for the composer rewrite.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T02:57:51Z

+export const MODEL_BUTTON_SELECTOR =
+  '[data-testid="model-switcher-dropdown-button"], button.__composer-pill[aria-haspopup="menu"]';


MODEL_BUTTON_SELECTOR is now a comma-separated selector list. document.querySelector() returns the first match in document order across either branch, so if any other button.__composer-pill[aria-haspopup="menu"] appears before the legacy [data-testid="model-switcher-dropdown-button"], callers can start clicking the wrong button (even on accounts where the legacy testid still exists). Consider replacing this constant with an ordered lookup (try legacy selector first, then the new pill), or otherwise narrowing the pill selector so it only matches the model picker.

Suggested change

export const MODEL_BUTTON_SELECTOR =

'[data-testid="model-switcher-dropdown-button"], button.__composer-pill[aria-haspopup="menu"]';

export const LEGACY_MODEL_BUTTON_SELECTOR =

'[data-testid="model-switcher-dropdown-button"]';

export const FALLBACK_MODEL_BUTTON_SELECTOR =

'button.__composer-pill[aria-haspopup="menu"]';

export const MODEL_BUTTON_SELECTORS = [

LEGACY_MODEL_BUTTON_SELECTOR,

FALLBACK_MODEL_BUTTON_SELECTOR,

] as const;

export const MODEL_BUTTON_SELECTOR = LEGACY_MODEL_BUTTON_SELECTOR;

Copilot · 2026-04-30T02:57:51Z

+    const OLD_CHIP_SELECTORS = [
+      '[data-testid="composer-footer-actions"] button[aria-haspopup="menu"]',
+      '.__composer-pill-composite button[aria-haspopup="menu"]',
+    ];
+    const findOldChip = () => {
+      for (const selector of OLD_CHIP_SELECTORS) {
+        for (const btn of document.querySelectorAll(selector)) {
          if (btn.getAttribute?.('aria-haspopup') !== 'menu') continue;
+          // The new model picker pill also reuses .__composer-pill — skip it.
+          if (btn.matches?.(MODEL_BUTTON_SELECTOR)) continue;
          const aria = normalize(btn.getAttribute?.('aria-label') ?? '');
          const text = normalize(btn.textContent ?? '');
-          if (aria.includes('thinking') || text.includes('thinking')) {
-            return btn;
-          }
-
-          // In some cases the pill is labeled "Pro".
-          if (aria.includes('pro') || text.includes('pro')) {
-            return btn;
-          }
+          if (aria.includes('thinking') || text.includes('thinking')) return btn;
+        }


findOldChip() currently skips any button matching MODEL_BUTTON_SELECTOR. Since MODEL_BUTTON_SELECTOR now includes button.__composer-pill[aria-haspopup="menu"], this can also exclude the legacy "Thinking" chip in UIs where it used the __composer-pill class (which the old implementation explicitly handled). That would prevent the fallback path from ever running and silently degrade to default effort even though the old chip is present. Consider restoring a selector path for button.__composer-pill while disambiguating by label/text (e.g., require "thinking" tokens) rather than excluding via MODEL_BUTTON_SELECTOR.

Copilot · 2026-04-30T02:57:51Z

+    const modelBtn = findModelButton();
+    if (!modelBtn) {
      return { status: 'chip-not-found' };
    }

-    dispatchClickSequence(chip);
+    // Open model menu (idempotent — leaves it open if already open).
+    if (modelBtn.getAttribute('aria-expanded') !== 'true') {
+      dispatchClickSequence(modelBtn);
+      await sleep(INITIAL_WAIT_MS);
+    }

-    return new Promise((resolve) => {
-      const start = performance.now();
+    let trailing = null;
+    const trailingDeadline = performance.now() + MAX_WAIT_MS;
+    while (performance.now() < trailingDeadline) {
+      trailing = pickTrailingForCurrentModel();
+      if (trailing) break;
+      await sleep(100);
+    }
+    if (!trailing) {
+      closeOpenMenus();
+      return { status: 'chip-not-found' };
+    }


The expression returns { status: 'chip-not-found' } for multiple different failure modes (no model button, no trailing effort button). This makes logs/debug dumps harder to interpret and can hide which selector actually broke. Consider adding distinct statuses (e.g. model-button-not-found, effort-button-not-found) and mapping them to clearer log contexts in ensureThinkingTime.

Copilot · 2026-04-30T02:57:51Z

+    // Bilingual matchers: English level token + observed Chinese variants.
+    const LEVEL_TOKENS = {
+      light: ['light', '轻'],
+      standard: ['standard', '标准'],
+      extended: ['extended', '扩展', '深度', '加强'],
+      heavy: ['heavy', '重度', '加重', '高'],
+    };
+    const targetTokens = LEVEL_TOKENS[TARGET_LEVEL] || [TARGET_LEVEL];


There are existing unit tests for the generated browser expression (tests/browser/thinkingTime.test.ts), but they don’t currently assert the new behavior introduced here (MODEL_BUTTON_SELECTOR inclusion and bilingual LEVEL_TOKENS). Adding assertions for these literals would help catch future UI selector regressions without needing a live smoke test.

needsmoretime · 2026-04-30T10:37:40Z

Thank you for this. Do you know how to have it select Configure so that older models like 5.4 Pro can be used? I wasn't able to get that working.

SyntaxSmith · 2026-04-30T11:25:39Z

Thank you for this. Do you know how to have it select Configure so that older models like 5.4 Pro can be used? I wasn't able to get that working.

No,I have no idea. Maybe you can choose it manually and this tool will use it by default

steipete · 2026-05-03T16:51:25Z

Superseded by #158, which landed the focused ChatGPT composer-pill model selector and thinking-effort menu fix from this PR, with updated tests and CHANGELOG credit. Thanks @SyntaxSmith.

Copilot AI review requested due to automatic review settings April 30, 2026 02:54

Copilot started reviewing on behalf of SyntaxSmith April 30, 2026 02:54 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

pdurlej mentioned this pull request Apr 30, 2026

feat(browser): support GPT-5.5 Pro in ChatGPT browser mode #147

Closed

steipete mentioned this pull request May 3, 2026

fix: track ChatGPT composer pill rewrite #158

Merged

steipete closed this May 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ChatGPT composer-pill DOM rewrite (model + thinking-effort)#146

Fix ChatGPT composer-pill DOM rewrite (model + thinking-effort)#146
SyntaxSmith wants to merge 1 commit into
steipete:mainfrom
SyntaxSmith:fix/chatgpt-composer-pill-dom

SyntaxSmith commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

needsmoretime commented Apr 30, 2026

Uh oh!

SyntaxSmith commented Apr 30, 2026

Uh oh!

steipete commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		export const MODEL_BUTTON_SELECTOR =
		'[data-testid="model-switcher-dropdown-button"], button.__composer-pill[aria-haspopup="menu"]';

-export const MODEL_BUTTON_SELECTOR =
-  '[data-testid="model-switcher-dropdown-button"], button.__composer-pill[aria-haspopup="menu"]';
+export const LEGACY_MODEL_BUTTON_SELECTOR =
+  '[data-testid="model-switcher-dropdown-button"]';
+export const FALLBACK_MODEL_BUTTON_SELECTOR =
+  'button.__composer-pill[aria-haspopup="menu"]';
+export const MODEL_BUTTON_SELECTORS = [
+  LEGACY_MODEL_BUTTON_SELECTOR,
+  FALLBACK_MODEL_BUTTON_SELECTOR,
+] as const;
+export const MODEL_BUTTON_SELECTOR = LEGACY_MODEL_BUTTON_SELECTOR;

Conversation

SyntaxSmith commented Apr 30, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

needsmoretime commented Apr 30, 2026

Uh oh!

SyntaxSmith commented Apr 30, 2026

Uh oh!

steipete commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants