Skip to content

fix: landing and docs overflow in mobile#94

Closed
eddsaura wants to merge 1 commit intosteipete:mainfrom
eddsaura:fix-site-overflow
Closed

fix: landing and docs overflow in mobile#94
eddsaura wants to merge 1 commit intosteipete:mainfrom
eddsaura:fix-site-overflow

Conversation

@eddsaura
Copy link
Copy Markdown

Hey, just a quick fix for the home page on mobile.

The pre element needed overflow.

Before

image

Now

image

@steipete
Copy link
Copy Markdown
Owner

steipete commented Mar 7, 2026

Closing as duplicate of #118. Both target the same mobile overflow problem, but #118 is the stronger version: broader coverage and it updates the source stylesheet at docs/assets/site.css rather than only the generated site copy.

@steipete steipete closed this Mar 7, 2026
@steipete
Copy link
Copy Markdown
Owner

steipete commented Mar 7, 2026

Adding a fuller duplicate note for future triage:

#94 and #118 target the same mobile website overflow family, but #118 is the better canonical PR for review because it is broader and edits the source stylesheet instead of only the generated output.

Why #118 is the keeper:

  • It updates , which is the source asset used by the site, rather than only , which is generated output.
  • It covers the wider mobile responsiveness problem, not just the single overflow symptom.
  • It adds breakpoint/layout handling that is more likely to survive the next site rebuild.

So closing #94 was not a judgment on the bug report quality; it was just consolidation onto the PR that fixes the same problem at the right layer and with broader coverage.

@steipete
Copy link
Copy Markdown
Owner

steipete commented Mar 7, 2026

Adding a fuller duplicate note for future triage:

#94 and #118 target the same mobile website overflow family, but #118 is the better canonical PR for review because it is broader and edits the source stylesheet instead of only the generated output.

Why #118 is the keeper:

  • It updates docs/assets/site.css, which is the source asset used by the site, rather than only docs/site/assets/site.css, which is generated output.
  • It covers the wider mobile responsiveness problem, not just the single pre overflow symptom.
  • It adds breakpoint/layout handling that is more likely to survive the next site rebuild.

So closing #94 was not a judgment on the bug report quality; it was just consolidation onto the PR that fixes the same problem at the right layer and with broader coverage.

@steipete
Copy link
Copy Markdown
Owner

steipete commented Mar 7, 2026

Plain-text clarification: #118 is the better canonical PR because it updates the source stylesheet in docs/assets/site.css, not just the generated site copy, and it addresses the broader mobile responsiveness problem rather than only the single pre-overflow symptom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants