Skip to content

chore: standardize npm release workflow#111

Merged
jan-kubica merged 1 commit into
mainfrom
codex/npm-version-release
Jun 4, 2026
Merged

chore: standardize npm release workflow#111
jan-kubica merged 1 commit into
mainfrom
codex/npm-version-release

Conversation

@jan-kubica
Copy link
Copy Markdown
Contributor

Summary

  • add VERSION as the release source for @stll/stdnum
  • replace the manual existing-tag release flow with the shared VERSION preflight/finalizer workflow from stella/.github
  • add version:check/version:sync and a CI version-sync guard so VERSION and package.json cannot drift

Merging this PR is expected to trigger the release workflow for 2.0.0; that version is not currently present on npm, has no git tag, and has no GitHub release.

Validation

  • node scripts/version-sync.mjs check
  • actionlint .github/workflows/ci.yml .github/workflows/release.yml
  • git diff --check

CC on behalf of @jan-kubica

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a version synchronization and checking utility via a new Node.js script (scripts/version-sync.mjs), a VERSION file, and corresponding npm scripts in package.json. Feedback on the changes suggests improving the execution flow in the script's main function by validating the command argument before attempting to parse and validate the version, which ensures that usage instructions are shown immediately on invalid input.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread scripts/version-sync.mjs
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26f597bc51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml
@jan-kubica jan-kubica force-pushed the codex/npm-version-release branch from 26f597b to 61d7ae5 Compare June 4, 2026 08:22
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61d7ae5f8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml
@jan-kubica jan-kubica force-pushed the codex/npm-version-release branch from 61d7ae5 to 3acdb38 Compare June 4, 2026 08:32
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3acdb38f90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml
@jan-kubica jan-kubica force-pushed the codex/npm-version-release branch from 3acdb38 to 09bbbe9 Compare June 4, 2026 08:41
@jan-kubica jan-kubica merged commit b2f223f into main Jun 4, 2026
8 checks passed
@jan-kubica jan-kubica deleted the codex/npm-version-release branch June 4, 2026 08:51
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant