You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR wires the stdnum repo into the shared stella/ai-shared AI command infrastructure by adding the shared repo as a git submodule, generating and checking in flat command files for both Claude (.claude/commands/) and agent (.agents/skills/) tooling, and documenting the setup in CONTRIBUTING.md. No runtime library code is changed.\n\n- Both concerns raised in prior review threads are now fully resolved: CONTRIBUTING.md includes the git submodule update --init step, and scripts/sync-ai-skills.sh has an explicit guard that exits with a clear error message if the submodule has not been initialized.\n- The sync-ai package.json script correctly delegates to the local wrapper, which in turn delegates to the shared script with . as the repo root argument.\n- The .gitignore sentinels in .agents/skills/ and .claude/commands/ contain no actual ignore rules — they exist only to keep the directories tracked in git. This is intentional and consistent with the "generated but also committed" pattern described in the PR.\n- The submodule is pinned to commit 75a0db2, which is the expected practice for reproducibility.
Confidence Score: 5/5
Safe to merge — no runtime library code changed and all previously raised concerns are addressed.
Both prior review concerns (missing submodule init step in docs, no guard in the sync script) have been resolved. The changes are purely infrastructure/tooling with no impact on the library itself. The script, documentation, and generated files are all consistent and correct.
No files require special attention.
Important Files Changed
Filename
Overview
scripts/sync-ai-skills.sh
New wrapper script that guards against uninitialized submodule before delegating to the shared script — addresses the previously raised concern cleanly.
CONTRIBUTING.md
Documents the AI command layout and includes the required git submodule update --init step before bun run sync-ai — addresses the previously raised concern.
.gitmodules
Registers .ai/shared as a submodule pointing to stella/ai-shared over HTTPS; submodule is pinned to a specific commit.
package.json
Adds sync-ai script entry; no other logic changes.
.agents/skills/.gitignore
Sentinel file to keep the directory tracked in git even when no skill files are present; contains only comments, no actual ignore rules (intentional).
.claude/commands/.gitignore
Same sentinel pattern as .agents/skills/.gitignore; generated command files are also committed alongside it.
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[bun run sync-ai] --> B[scripts/sync-ai-skills.sh]
B --> C{.ai/shared initialized?}
C -- No --> D["error: submodule not initialized\nexit 1"]
C -- Yes --> E[.ai/shared/scripts/sync-ai-skills.sh .]
E --> F[.claude/commands/*.md]
E --> G[.agents/skills/*.md]
subgraph Sources
H[.ai/shared/skills/] -->|shared skills| E
I[.ai/local-skills/] -->|repo-local additions| E
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stella/ai-sharedas the.ai/sharedsubmodule.ai/local-skillsand abun run sync-aiwrapper.claude/commandsand.agents/skillsCONTRIBUTING.mdVerification
bun run sync-aiNotes
.ai/sharedis pinned tostella/ai-sharedcommit75a0db2