Skip to content

chore: wire stdnum to shared AI commands#78

Merged
jan-kubica merged 3 commits intomainfrom
codex/ai-setup
Mar 26, 2026
Merged

chore: wire stdnum to shared AI commands#78
jan-kubica merged 3 commits intomainfrom
codex/ai-setup

Conversation

@jan-kubica
Copy link
Copy Markdown
Contributor

@jan-kubica jan-kubica commented Mar 26, 2026

Summary

  • add stella/ai-shared as the .ai/shared submodule
  • add repo-local .ai/local-skills and a bun run sync-ai wrapper
  • generate and check in the flat shared command lists under .claude/commands and .agents/skills
  • document the setup in CONTRIBUTING.md

Verification

  • bun run sync-ai

Notes

  • no runtime library code changed
  • .ai/shared is pinned to stella/ai-shared commit 75a0db2

Open with Devin

devin-ai-integration[bot]

This comment was marked as resolved.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 26, 2026

Greptile Summary

This PR wires the stdnum repo into the shared stella/ai-shared AI command infrastructure by adding the shared repo as a git submodule, generating and checking in flat command files for both Claude (.claude/commands/) and agent (.agents/skills/) tooling, and documenting the setup in CONTRIBUTING.md. No runtime library code is changed.\n\n- Both concerns raised in prior review threads are now fully resolved: CONTRIBUTING.md includes the git submodule update --init step, and scripts/sync-ai-skills.sh has an explicit guard that exits with a clear error message if the submodule has not been initialized.\n- The sync-ai package.json script correctly delegates to the local wrapper, which in turn delegates to the shared script with . as the repo root argument.\n- The .gitignore sentinels in .agents/skills/ and .claude/commands/ contain no actual ignore rules — they exist only to keep the directories tracked in git. This is intentional and consistent with the "generated but also committed" pattern described in the PR.\n- The submodule is pinned to commit 75a0db2, which is the expected practice for reproducibility.

Confidence Score: 5/5

Safe to merge — no runtime library code changed and all previously raised concerns are addressed.

Both prior review concerns (missing submodule init step in docs, no guard in the sync script) have been resolved. The changes are purely infrastructure/tooling with no impact on the library itself. The script, documentation, and generated files are all consistent and correct.

No files require special attention.

Important Files Changed

Filename Overview
scripts/sync-ai-skills.sh New wrapper script that guards against uninitialized submodule before delegating to the shared script — addresses the previously raised concern cleanly.
CONTRIBUTING.md Documents the AI command layout and includes the required git submodule update --init step before bun run sync-ai — addresses the previously raised concern.
.gitmodules Registers .ai/shared as a submodule pointing to stella/ai-shared over HTTPS; submodule is pinned to a specific commit.
package.json Adds sync-ai script entry; no other logic changes.
.agents/skills/.gitignore Sentinel file to keep the directory tracked in git even when no skill files are present; contains only comments, no actual ignore rules (intentional).
.claude/commands/.gitignore Same sentinel pattern as .agents/skills/.gitignore; generated command files are also committed alongside it.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[bun run sync-ai] --> B[scripts/sync-ai-skills.sh]
    B --> C{.ai/shared initialized?}
    C -- No --> D["error: submodule not initialized\nexit 1"]
    C -- Yes --> E[.ai/shared/scripts/sync-ai-skills.sh .]
    E --> F[.claude/commands/*.md]
    E --> G[.agents/skills/*.md]

    subgraph Sources
        H[.ai/shared/skills/] -->|shared skills| E
        I[.ai/local-skills/] -->|repo-local additions| E
    end
Loading

Reviews (2): Last reviewed commit: "Clarify AI sync prerequisites" | Re-trigger Greptile

greptile-apps[bot]

This comment was marked as resolved.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread .claude/commands/open-pr.md
@jan-kubica jan-kubica changed the title Wire stdnum to shared AI commands chore: wire stdnum to shared AI commands Mar 26, 2026
@jan-kubica jan-kubica merged commit 0afe255 into main Mar 26, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant