This repository was archived by the owner on Jun 22, 2021. It is now read-only.
Fix incorrect example #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalepail
reviewed
Jan 22, 2020
guides/get-started/transactions.md
Outdated
| .catch(function (error) { | ||
| if (error instanceof StellarSdk.NotFoundError) { | ||
| throw new Error('The destination account does not exist!'); | ||
| } |
Contributor
There was a problem hiding this comment.
Needs to return the error if not an instanceof StellarSdk.NotFoundError otherwise the error will get caught here and not follow through to any subsequent catch blocks
vcarl
commented
Jan 22, 2020
Comment on lines
+58
to
64
| .catch(function (error) { | ||
| if (error instanceof StellarSdk.NotFoundError) { | ||
| throw new Error('The destination account does not exist!'); | ||
| } else return error | ||
| }) | ||
| // If there was no error, load up-to-date information on your account. | ||
| .then(function() { |
Contributor
Author
There was a problem hiding this comment.
It occurs to me that this demo code is broken in other ways: it says "if there was no error…" but this .then will always execute because .catch returns a resolved promise
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per stellar/js-stellar-sdk#479, the example code here doesn't work.