Skip to content
This repository was archived by the owner on Jun 22, 2021. It is now read-only.

Conversation

@msfeldstein
Copy link
Contributor

'can be set' was confusing, the values will be set to true or false, but if its immutable it cannot be changed

'can be set' was confusing, the values will be set to true or false, but if its immutable it cannot be changed
Copy link
Contributor

@vcarl vcarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

Copy link
Contributor

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is clearer. I manually confirmed with stellar lab that flags can be neither set nor unset, as expected.

@vcarl vcarl merged commit 7a8fee3 into master Mar 5, 2020
@vcarl vcarl deleted the msfeldstein-patch-1 branch March 5, 2020 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants