Fix uploading plugin artifact #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkweb
approved these changes
Feb 13, 2025
Member
|
Thank you for the fix, @shvlv! 🕺 |
shvlv
added a commit
to stellarwp/pup
that referenced
this pull request
Feb 13, 2025
borkweb
added a commit
to stellarwp/pup
that referenced
this pull request
Feb 14, 2025
Update the documentation to stay in sync with stellarwp/github-actions#15 changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The uploading artifact fails with
Warning: No files were found with the provided path: .pup-zip. No artifacts will be uploaded.notice.Solution
It's related to the BC of
actions/upload-artifact@v4:include-hidden-filesis false by default (see https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#hidden-files). That's why we must addinclude-hidden-files: trueto upload files from the.pup-zipdirectory. I've tested it in our project; it works as expected.