fix: gate phpcs job on reviewdog result, not phpcs whole-file exit code

[WayneRocha]

Problem

After #22 and #23, the phpcs job still fails on PRs that introduce no new violations.

The Run reviewdog step ends with:

exit $PHPCS_EXIT_CODE

So the job's pass/fail is driven by phpcs's exit code. But phpcs scans the whole changed file, so its exit code reflects every issue in that file — including pre-existing ones on lines the PR never touched. reviewdog, by contrast, runs with -filter-mode=added and only reports/fails on issues introduced on the PR's added lines.

The two disagree, and the job exits on the phpcs code.

Reproduction — the-events-calendar#5687 "clean" test (bf090fc)

From the job log:

mapfile -t FILES <<< "src/functions/views/provider.php"
##[error]Process completed with exit code 2.

• phpcs scanned provider.php, found pre-existing issues → exited 2.
• Those issues are not on the PR's added lines, so reviewdog filtered them out → no inline comment ("No bot display").
• Then exit $PHPCS_EXIT_CODE ran exit 2 → job failed anyway.

#22/#23 focused on faithfully preserving the phpcs exit code — which is exactly the value that should not gate the job.

Fix

• Run phpcs with --report=checkstyle and pipe straight to reviewdog (-f=checkstyle), dropping the jq transform.
• Exit with reviewdog's exit code, not phpcs's. -filter-mode=added -fail-level=any means reviewdog exits 1 only when it reports a violation on a line this PR changed.
• Keep a guard: if phpcs produces no checkstyle output and exits non-zero, it genuinely failed to run (bad standard, parse error, …) → fail the job with phpcs's code.

set +e
CHECKSTYLE_REPORT=$(vendor/bin/phpcs --report=checkstyle -q "${FILES[@]}")
PHPCS_EXIT_CODE=$?
set -e

if [ -z "$CHECKSTYLE_REPORT" ] && [ "$PHPCS_EXIT_CODE" -ne 0 ]; then
  echo "phpcs failed to run (exit code $PHPCS_EXIT_CODE)"
  exit "$PHPCS_EXIT_CODE"
fi

REVIEWDOG_EXIT_CODE=0
echo "$CHECKSTYLE_REPORT" \
  | reviewdog -f=checkstyle -name="phpcs" -filter-mode="added" -fail-level=any -reporter=github-pr-review \
  || REVIEWDOG_EXIT_CODE=$?

exit "$REVIEWDOG_EXIT_CODE"

Expected behavior across the-events-calendar#5687 test commits

Commit	Introduces new violations?	reviewdog comment	Job
Test 1 / Test 2	yes	posted	fails ✅
Test 3 (clean)	no (pre-existing only)	none	passes ✅

Test PR

the-events-calendar#5687 repointed to @fix/phpcs-reviewdog-exit-code to re-run all three scenarios.

Created by claude 🤖