Show Unactivated badge on locked tiers for unactivated licenses#123
Merged
pauloiankoski merged 9 commits intodevelopfrom Apr 28, 2026
Merged
Show Unactivated badge on locked tiers for unactivated licenses#123pauloiankoski merged 9 commits intodevelopfrom
pauloiankoski merged 9 commits intodevelopfrom
Conversation
…, and upgrade URL
87094be to
345ad13
Compare
Contributor
Author
|
I'm just concerned that I'm seeing too many |
…active lower tier
78d6c53 to
d6f77b3
Compare
jonwaldstein
previously approved these changes
Apr 28, 2026
Contributor
jonwaldstein
left a comment
There was a problem hiding this comment.
@pauloiankoski nice! I hear you on the badge but I think its fine for now 😏
We released v1.0.0 already so we should probably create a release branch instead of margin into master and add any since tags
| } | ||
|
|
||
| /** | ||
| * @since 1.0.0 |
Contributor
There was a problem hiding this comment.
We'll have to add a new TBD release tag now 😄
Contributor
Author
There was a problem hiding this comment.
Added TBD since tag and changed base to develop branch.
6612a76 to
7d0a020
Compare
jonwaldstein
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 161
Summary
Fixes an edge case where a user with a valid but unactivated license (domain not yet in the activations list) was shown upgrade buttons for tiers they already own.
When
activated_here: falseandvalidation_status: "not_activated", the hook couldn't find alicenseProduct, which leftrank = -1and routed every catalog tier intoupgradeCatalogTiers— presenting "Upgrade to Pro" buttons to someone who already purchased Pro.getUnactivatedLicenseProductselector that finds a license product the user owns but hasn't activated on this domainuseProductFeatureGroupsfalls back to the unactivated product for rank computation; tiers at or below that rank move toactivationCatalogTiersinstead ofupgradeCatalogTiers; exposesisUnactivatedLicenseflagshowUnactivatedprop rendersLicenseBadge type="unactivated"in the upgrade-button slotshowUnactivatedto activation tier groups; foldsisUnactivatedLicenseintoisNotActivatedso the product header shows "Unactivated" instead of "Unlicensed"; useslicenseProduct ?? unactivatedLicenseProductforbuttonHrefso subscribers with an unactivated license are routed to the change-plan portal flow rather than a freshpurchase_urlArtifacts
Before

After
