Conversation
JasonTheAdams
suggested changes
Aug 30, 2024
Contributor
JasonTheAdams
left a comment
There was a problem hiding this comment.
Good add! Can we please add a unit test for this?
Thank you!
Contributor
Author
@JasonTheAdams added float to the type test. |
JasonTheAdams
suggested changes
Sep 6, 2024
Co-authored-by: Jason Adams <jason.the.adams@gmail.com>
JasonTheAdams
approved these changes
Sep 6, 2024
Contributor
JasonTheAdams
left a comment
There was a problem hiding this comment.
Love it! This is great! Minor suggestion on the test, but otherwise good!
Co-authored-by: Jason Adams <jason.the.adams@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
floatdatatype.