TypeScript Rewrite: Workflow command#37
Open
d4mation wants to merge 15 commits intoENG-219/app-bootstrapfrom
Open
TypeScript Rewrite: Workflow command#37d4mation wants to merge 15 commits intoENG-219/app-bootstrapfrom
d4mation wants to merge 15 commits intoENG-219/app-bootstrapfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d4mation
added
the
On Hold
Add tests verifying --root changes the working directory for workflow command execution. Update the option description to make it clear that --root controls where commands run, not where config is loaded from.
d4mation
commented
Feb 12, 2026
| .command('workflow <workflow>') | ||
| .alias('do') | ||
| .description('Run a command workflow.') | ||
| .option('--root <dir>', 'Run workflow commands in the given directory instead of the current working directory.') |
Contributor
Author
There was a problem hiding this comment.
This is how this flag worked in the PHP version as well. The description for it just wasn't clear.
The getConfig() singleton is already initialized in createApp() before commands run, so passing options.root has no effect. The --root flag correctly controls the cwd for subprocess execution, not config loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 ENG-219
Reference
Summary
workflowcommand (aliased asdo) that runs named workflow sequences defined in.puprc--separatorenvconfigurationDependencies
This PR depends on #30 (app-bootstrap) being merged first.
Test plan
npx pup workflow <name>runs the configured workflownpx pup do <name>alias works--separator