Fix - multsite table up #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the logic put in place in [this commit](fba6dc4) to keep the spirit (avoid a db query on each run of the `Builder::up()` method, but avoid the call to `is_blog_installed` that, when fired too early in multisite installations, would kill the database. What is the issue? The `Builder::up` is called, by means of the `Builder::update_blog_tables` on `switch_blog`. The `switch_blog` function is called during the creation of blogs as well, in the `wp_initialize_site` function. The blog **is being installed**, it's not installed yet. Running `is_blog_installed()` in this phase will kill the site as it will find a broken db: the `users` table is there (it' common to all blogs), but the `options` table is not. This PR handles this scenario, delaying the creation of the tables to the `activate_blog` or `switch_blog` calls following the creation of the site or future requests.
dpanta94
approved these changes
Jul 18, 2025
Camwyn
reviewed
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic put in place in this
commit
to keep the spirit (avoid a db query on each run of the
Builder::up()method, but avoid the call to
is_blog_installedthat, when fired tooearly in multisite installations, would kill the database.
What is the issue?
The
Builder::upis called, by means of theBuilder::update_blog_tablesonswitch_blog.The
switch_blogfunction is called during the creation of blogs aswell, in the
wp_initialize_sitefunction.The blog is being installed, it's not installed yet.
Running
is_blog_installed()in this phase will kill the site as itwill find a broken db: the
userstable is there (it' common to allblogs), but the
optionstable is not.This PR handles this scenario, delaying the creation of the tables to
the
activate_blogorswitch_blogcalls following the creation of thesite or future requests.