Skip to content

Comments

Addresses table registration and scheduling issues#15

Merged
dpanta94 merged 34 commits intomainfrom
fix/as-schedule-action-and-table-registration
Sep 8, 2025
Merged

Addresses table registration and scheduling issues#15
dpanta94 merged 34 commits intomainfrom
fix/as-schedule-action-and-table-registration

Conversation

@dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Sep 1, 2025

Addresses issues related to table registration and action scheduling.

  • Ensures the regulator is registered only after successful table creation/update.
  • Makes sure that the offset is increased after every batch is queried
  • Modifies action scheduling to return 0 if the action ID is invalid.
  • Corrects a typo in the Tasks table schema version.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • ⚡ Performance improvement
  • ♻️ Code refactoring
  • 🧪 Test improvements
  • 🔧 Chore (build process, dependencies, etc.)

Related Issues

Closes
TCMN-194
TCMN-195
TCMN-196
TCMN-197
TCMN-199

Pre-Submission Checklist

Code Quality

  • PHPStan analysis passes: composer test:analysis
  • PHP compatibility check passes: composer compatibility
  • Coding standards pass: vendor/bin/phpcs
  • All tests pass: slic run wpunit && slic run integration
  • No debug code (var_dump, error_log, etc.) left in production code
  • No commented-out code unless specifically needed for reference
  • Documentation updated for any new features or changed behavior
  • New tests have been added for new functionality
  • All existing tests continue to pass

📖 Read the full contributing guidelines: CONTRIBUTING.md

@dpanta94 dpanta94 self-assigned this Sep 1, 2025
@dpanta94 dpanta94 added the enhancement New feature or request label Sep 1, 2025
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left questions, but the code, if the answer to all the questions is fine, is good to go.

Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove partial mocking from tests and all good to go.

@dpanta94 dpanta94 merged commit 94ed314 into main Sep 8, 2025
11 checks passed
@dpanta94 dpanta94 deleted the fix/as-schedule-action-and-table-registration branch September 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants