Fix SLIC_WP_AUTO_UPDATE_CORE handling #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y include all updates since it was executed
While the `use` command is being handled, the project path will still point at the `here` target, not the new target set by the `use` command. I.e. the `get_project_local_path()` function will return `/home/wp/wp-content/plugins` and not `/home/wp/wp-content/plugins/the-events-calendar`. From this follows that the project configuration files will be read from the `/home/wp/wp-content/plugins` directory and not from the `/home/wp/wp-content/plugins/the-events-calendar` one invlalidating the effect of some of the env vars defined in files like the `.env.slic.local` that might be present in the project directory (`the-events-calendar` in this case). By setting the project path early during a `use` command handling, env vars that affect the docker stack (e.g. the `SLIC_DB_NO_MIN` one) will correctly have the desired effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Important
This includes an awesome bug fix to properly read a project's
.env.slic.localso overriding now works in all scenarios when runningslic use <project>.usecommand to guarantee that project specific override files will apply to all operations performed during the handling of theusecommand, including possible spin up of the stack.SLIC_WP_AUTO_UPDATE_CORE, allow "undefining" this env var withSLIC_WP_AUTO_UPDATE_CORE=SLIC_AUTOMATIC_UPDATER_DISABLED, allow "undefining" this env var withSLIC_AUTOMATIC_UPDATER_DISABLED=SLIC_WP_HTTP_BLOCK_EXTERNAL, allow "undefining" this env var withSLIC_WP_HTTP_BLOCK_EXTERNAL=update-dumpcommand now validates dump file existence before processing, provides clearer progress messages, and properly restores the original WordPress version after testing with a specific version.read_env_file()no longer reads commented out env vars, e.g.# SOME_VAR=testwould previously be set.