[FRAME-156]: Add Events#77
Conversation
ChrisMKindred
left a comment
There was a problem hiding this comment.
This all looks good. Should we look into using version/tag branches so you don't have to use the TBD in the since param? I am concerned that merging directly to Main without a version branch could result in that TBD getting left in before a deployment.
|
I recommend creating a |
|
Hey @ChrisMKindred, here's a link to the subset of most recent changes that should make it a little easier to see what I did. Mainly two things:
Let me know if you have any questions or suggestions. |
ChrisMKindred
left a comment
There was a problem hiding this comment.
Looks good and is fine to merge. Could we add the mocking as a setup function? It is repetitive for us to create the array and function mock in each test.
This adds the ability to trigger specific events with a
do_action()so additional data can be collected from sites when users perform specific actions.