Skip to content

Prevent fatal error if parent plugin is deleted without activating#81

Merged
tarecord merged 3 commits into
stellarwp:developfrom
oakesjosh:develop
Aug 21, 2023
Merged

Prevent fatal error if parent plugin is deleted without activating#81
tarecord merged 3 commits into
stellarwp:developfrom
oakesjosh:develop

Conversation

@oakesjosh
Copy link
Copy Markdown
Contributor

If the parent plugin is installed, but not activated, stellarwp_telemetry is not set. When deleting the plugin, the default value of false is passed to the count() function which will throw a warning on php 7.2+ and fatal error on 8.0+.

Steps to recreate

  • Install Kadence Blocks (3.1.*) on a site without a stellarwp_telemetry entry in options table
  • Do not activate plugin
  • Attempt to delete plugin via wp-admin

@tarecord tarecord self-requested a review August 21, 2023 19:48
@tarecord tarecord changed the base branch from develop to release/2.0.2 August 21, 2023 20:02
@tarecord tarecord changed the base branch from release/2.0.2 to develop August 21, 2023 20:03
@tarecord tarecord merged commit f18167f into stellarwp:develop Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants