[FRAME-170]: Add functionality to pass opt_in_text to opt-in#86
Merged
Conversation
We need a way to get the opt-in-text without needing to query through the list of active plugins so we can send the text with the user registration.
ChrisMKindred
suggested changes
Sep 29, 2023
| 'name' => $user->display_name, | ||
| 'email' => $user->user_email, | ||
| 'plugin_slug' => $stellar_slug, | ||
| 'opt_in_text' => $template->get_intro( $user->display_name, $stellar_slug ), |
Contributor
There was a problem hiding this comment.
Don't we allow the plugins to filter this value? Is there a chance that we will be pushing a different value than what they approved if that is the case?
ChrisMKindred
approved these changes
Oct 2, 2023
Contributor
ChrisMKindred
left a comment
ChrisMKindred
left a comment
There was a problem hiding this comment.
This looks much cleaner. 🌮
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
opt_in_textand properly passes that along in the opt-in request to support https://github.com/stellarwp/telemetry-server/pull/72