[FRAME-180]: Refactor to remove "Mixed" status#88
Merged
Conversation
ChrisMKindred
suggested changes
Sep 29, 2023
Contributor
ChrisMKindred
left a comment
ChrisMKindred
left a comment
There was a problem hiding this comment.
This this is a great cleanup for a confusing piece and the tests help make it very clear what is expected from the function. I am concerned that we are changing the signature of a public method. This is all good as long as Stellar is good with the breaking change that causes. Let's make sure we aren't causing a problem with that before merging.
We can't change the function signature to use a bool return type because it could break existing implementations out in the wild.
Member
Author
|
@ChrisMKindred - Good point, I've reverted back to using integers (1 - Active, 2 - Inactive) and added another test to cover the |
ChrisMKindred
approved these changes
Oct 2, 2023
Contributor
ChrisMKindred
left a comment
ChrisMKindred
left a comment
There was a problem hiding this comment.
👍 much better not requiring a depreciation now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the status to return a boolean whether the site is opted in or not. I also added some additional tests to verify things are working as expected.