Skip to content

Improve Test Coverage#95

Merged
tarecord merged 15 commits into
feature/qa-simplificationfrom
feature/FRAME-179/fill-out-php-tests
Oct 13, 2023
Merged

Improve Test Coverage#95
tarecord merged 15 commits into
feature/qa-simplificationfrom
feature/FRAME-179/fill-out-php-tests

Conversation

@tarecord
Copy link
Copy Markdown
Member

@tarecord tarecord commented Oct 5, 2023

This handles setting up code coverage measuring and improves our test coverage quite a bit.

You can verify this locally with Slic.

First, you'll need to start XDebug to use it as a driver with:

slic xdebug on

Then you can run the tests and generate the coverage report in the tests/_output directory:

slic run --coverage-html tests/_output
image

@tarecord tarecord requested a review from ChrisMKindred October 5, 2023 19:38
@tarecord tarecord self-assigned this Oct 5, 2023
@tarecord tarecord changed the base branch from develop to feature/qa-simplification October 5, 2023 19:38
@tarecord
Copy link
Copy Markdown
Member Author

tarecord commented Oct 9, 2023

There's a lot more tests to cover now that the core class has tests (which reveals all the rest of the classes in the library). I've done about all I can do for now.

Testing is a never-ending endeavor, but this should provide a good base to build on when features are added or refactored.

@tarecord tarecord marked this pull request as ready for review October 9, 2023 20:45
Copy link
Copy Markdown
Contributor

@ChrisMKindred ChrisMKindred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @tarecord ! What are the chances you could do a walk-through on testing for the Biweekly sometime?

Comment thread tests/wpunit/TemplateTest.php Outdated
Comment thread tests/wpunit/TemplateTest.php Outdated
@tarecord tarecord merged commit ddfaf8d into feature/qa-simplification Oct 13, 2023
@tarecord tarecord deleted the feature/FRAME-179/fill-out-php-tests branch October 13, 2023 14:21
@tarecord tarecord mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants