fix: export DEFAULT_MODE from host-config to use it in platform-server and to prevent undefined as a bundle id.#1366
Merged
adamdbradley merged 1 commit intostenciljs:masterfrom Feb 12, 2019
Conversation
Contributor
Author
|
@adamdbradley Hey, could you take a look at those tests? I scrolled through them a few times and honestly it does not seem like a proper behaviour to me. Additionally all other Pull Requests are failing on those 3 as well which does not seem to be a coincidence. Also, this fix is sort of a hot topic for me as we are using Stencil to build our first product at what.digital and we need prerendering to satisfy our SEO needs. 🙏 |
ChBernat
changed the title
ChBernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix
of issue https://github.com/ionic-team/stencil/issues/1144. It is uses the very similar logic you've already used when getting bundleIds as array in a different place of an application thus I thought it will be a good idea to stick to this logic.
One more thing - when I was debugging I've noticed that ionic's components are giving me bundleIds for ios and md; Would it be a good idea to take that into notice at some point in time?