Skip to content

Add referrerPolicy to AnchorHTMLAttributes#3006

Merged
rwaskiewicz merged 4 commits intostenciljs:masterfrom
wavebeem:issue-2933-referrerPolicy-missing-on-AnchorHTMLAttributes
Aug 31, 2021
Merged

Add referrerPolicy to AnchorHTMLAttributes#3006
rwaskiewicz merged 4 commits intostenciljs:masterfrom
wavebeem:issue-2933-referrerPolicy-missing-on-AnchorHTMLAttributes

Conversation

@wavebeem
Copy link
Copy Markdown
Contributor

Add referrerPolicy to AnchorHTMLAttributes

Fixes #2933

@wavebeem wavebeem requested a review from a team August 17, 2021 21:33
Copy link
Copy Markdown
Member

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwaskiewicz rwaskiewicz merged commit 4f7c073 into stenciljs:master Aug 31, 2021
@rwaskiewicz
Copy link
Copy Markdown
Member

A quick note - the team is considering this a non-breaking change, as this shouldn't affect most folks using these types. For those that are doing type manipulations that stripping the optional aspect of this interface (e.g. type myType = Required<AnchorHTMLAttributes>), and are not specifying the referrerPolicy today in any way, set referrerPolicy to strict-origin-when-cross-origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute referrerPolicy is missing on AnchorHTMLAttributes

2 participants