Skip to content

chore: v5-add-other-dist-artifacts-to-skipInDev #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnjenkins merged 4 commits into from
Apr 13, 2026
Merged

chore: v5-add-other-dist-artifacts-to-skipInDev #6685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0a2321
chore: v5-add-other-dist-artifacts-to-skipInDev
johnjenkins Apr 13, 2026
0225f4f
chore:
johnjenkins Apr 13, 2026
896cbbd
chore:
johnjenkins Apr 13, 2026
baf53a5
chore:
johnjenkins Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/migrations/rules/build-dist-docs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const buildDistDocsRule: MigrationRule = {

if (isTrue) {
if (propName === 'buildDist') {
targetTypesNeedingSkipInDev.push('dist-custom-elements', 'dist-hydrate-script');
targetTypesNeedingSkipInDev.push('dist', 'dist-custom-elements', 'dist-hydrate-script');
} else if (propName === 'buildDocs') {
targetTypesNeedingSkipInDev.push(
'docs-readme',
Expand Down
109 changes: 4 additions & 105 deletions packages/core/src/compiler/config/_test_/validate-output-dist.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ describe('validateDistOutputTarget', () => {
typesDir: join(rootDir, 'my-dist', 'types'),
transformAliasedImportPathsInCollection: true,
isPrimaryPackageOutputTarget: false,
skipInDev: false,
skipInDev: true,
},

{
esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'),
empty: false,
Expand All @@ -57,40 +58,6 @@ describe('validateDistOutputTarget', () => {
file: join(rootDir, 'my-dist', 'my-build', 'testing', 'testing.css'),
type: 'dist-global-styles',
},
{
dir: join(rootDir, 'my-dist'),
type: 'dist-types',
typesDir: join(rootDir, 'my-dist', 'types'),
},
{
collectionDir: join(rootDir, 'my-dist', 'collection'),
dir: join(rootDir, '/my-dist'),
empty: false,
transformAliasedImportPaths: true,
type: 'dist-collection',
},
{
copy: [{ src: '**/*.svg' }, { src: '**/*.js' }],
copyAssets: 'collection',
dir: join(rootDir, 'my-dist', 'collection'),
type: 'copy',
},
{
type: 'dist-lazy',
cjsDir: join(rootDir, 'my-dist', 'cjs'),
cjsIndexFile: join(rootDir, 'my-dist', 'index.cjs.js'),
empty: false,
esmDir: join(rootDir, 'my-dist', 'esm'),
esmIndexFile: join(rootDir, 'my-dist', 'index.js'),
},
{
cjsDir: join(rootDir, 'my-dist', 'cjs'),
componentDts: join(rootDir, 'my-dist', 'types', 'components.d.ts'),
dir: join(rootDir, 'my-dist', 'loader'),
empty: false,
esmDir: join(rootDir, 'my-dist', 'esm'),
type: 'dist-lazy-loader',
},
]);
});

Expand Down Expand Up @@ -135,7 +102,7 @@ describe('validateDistOutputTarget', () => {
typesDir: join(rootDir, 'my-dist', 'types'),
transformAliasedImportPathsInCollection: true,
isPrimaryPackageOutputTarget: false,
skipInDev: false,
skipInDev: true,
},
{
esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'),
Expand All @@ -153,40 +120,6 @@ describe('validateDistOutputTarget', () => {
file: join(rootDir, 'my-dist', 'my-build', 'testing', 'testing.css'),
type: 'dist-global-styles',
},
{
dir: join(rootDir, 'my-dist'),
type: 'dist-types',
typesDir: join(rootDir, 'my-dist', 'types'),
},
{
collectionDir: join(rootDir, 'my-dist', 'collection'),
dir: join(rootDir, '/my-dist'),
empty: false,
transformAliasedImportPaths: true,
type: 'dist-collection',
},
{
copy: [{ src: '**/*.svg' }, { src: '**/*.js' }],
copyAssets: 'collection',
dir: join(rootDir, 'my-dist', 'collection'),
type: 'copy',
},
{
type: 'dist-lazy',
cjsDir: join(rootDir, 'my-dist', 'cjs'),
cjsIndexFile: join(rootDir, 'my-dist', 'index.cjs.js'),
empty: false,
esmDir: join(rootDir, 'my-dist', 'esm'),
esmIndexFile: join(rootDir, 'my-dist', 'index.js'),
},
{
cjsDir: join(rootDir, 'my-dist', 'cjs'),
componentDts: join(rootDir, 'my-dist', 'types', 'components.d.ts'),
dir: join(rootDir, 'my-dist', 'loader'),
empty: false,
esmDir: join(rootDir, 'my-dist', 'esm'),
type: 'dist-lazy-loader',
},
]);
});

Expand Down Expand Up @@ -215,7 +148,7 @@ describe('validateDistOutputTarget', () => {
typesDir: join(rootDir, 'my-dist', 'types'),
transformAliasedImportPathsInCollection: true,
isPrimaryPackageOutputTarget: true,
skipInDev: false,
skipInDev: true,
},
{
esmDir: join(rootDir, 'my-dist', 'my-build', 'testing'),
Expand All @@ -233,40 +166,6 @@ describe('validateDistOutputTarget', () => {
file: join(rootDir, 'my-dist', 'my-build', 'testing', 'testing.css'),
type: 'dist-global-styles',
},
{
dir: join(rootDir, 'my-dist'),
type: 'dist-types',
typesDir: join(rootDir, 'my-dist', 'types'),
},
{
collectionDir: join(rootDir, 'my-dist', 'collection'),
dir: join(rootDir, '/my-dist'),
empty: false,
transformAliasedImportPaths: true,
type: 'dist-collection',
},
{
copy: [{ src: '**/*.svg' }, { src: '**/*.js' }],
copyAssets: 'collection',
dir: join(rootDir, 'my-dist', 'collection'),
type: 'copy',
},
{
type: 'dist-lazy',
cjsDir: join(rootDir, 'my-dist', 'cjs'),
cjsIndexFile: join(rootDir, 'my-dist', 'index.cjs.js'),
empty: false,
esmDir: join(rootDir, 'my-dist', 'esm'),
esmIndexFile: join(rootDir, 'my-dist', 'index.js'),
},
{
cjsDir: join(rootDir, 'my-dist', 'cjs'),
componentDts: join(rootDir, 'my-dist', 'types', 'components.d.ts'),
dir: join(rootDir, 'my-dist', 'loader'),
empty: false,
esmDir: join(rootDir, 'my-dist', 'esm'),
type: 'dist-lazy-loader',
},
]);
});
});
4 changes: 2 additions & 2 deletions packages/core/src/compiler/config/outputs/validate-dist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ const validateOutputTargetDist = (
: true,
isPrimaryPackageOutputTarget: o.isPrimaryPackageOutputTarget ?? false,
cjs: isBoolean(o.cjs) ? o.cjs : false,
// dist always builds by default (skipInDev: false)
skipInDev: isBoolean(o.skipInDev) ? o.skipInDev : false,
// dist skips distribution artifacts in dev mode by default, but always builds browser/CDN output
skipInDev: isBoolean(o.skipInDev) ? o.skipInDev : true,
} satisfies Required<d.OutputTargetDist>;

if (!isAbsolute(outputTarget.buildDir)) {
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/compiler/output-targets/_test_/output-lazy-loader.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ function setup(configOverrides: Partial<d.ValidatedConfig> = {}) {
type: DIST,
dir: 'my-test-dir',
cjs: true,
skipInDev: false,
},
],
srcDir: '/src',
Expand Down
Loading