fix(aicli): handle detection for GitHub Copilot CLI version#48
Merged
ashishkurmi merged 3 commits intostep-security:mainfrom Apr 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves AI CLI tool detection by preventing false positives for the GitHub Copilot CLI when a VS Code extension shim is present on PATH and responds to --version with an installation prompt.
Changes:
- Add a
VerifyFuncforgithub-copilot-clithat rejects the “not installed / install prompt” output and requires a version-like token. - Add unit tests covering rejection of the install prompt and acceptance/parsing of a real Copilot CLI version.
- Adjust
cleanVersionStringto return"unknown"when no version token is found.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/detector/aicli.go |
Adds Copilot-specific verification logic and tightens version parsing fallback behavior. |
internal/detector/aicli_test.go |
Adds tests for Copilot CLI detection behavior (shim prompt vs real version). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d0f4060 to
62ecf52
Compare
ashishkurmi
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues