fix(paths): add support for expanding $HOME#99
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds home-directory token expansion to the agent install-dir resolution so values like $HOME/... and ~/... are turned into concrete paths before being used for logging/state locations.
Changes:
- Expand a leading
$HOMEor~inpaths.Home()inputs (CLI flag, env var, config field) via a newexpandHomehelper. - Add unit tests covering
$HOME/~expansion behavior and ensuring non-token absolute paths remain unchanged.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/paths/paths.go | Adds expandHome and applies it to all non-legacy Home() sources. |
| internal/paths/paths_test.go | Adds tests validating $HOME/~ expansion in config/env/CLI sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ashishkurmi
approved these changes
May 22, 2026
ashishkurmi
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues