Initial release of get-cmake action by amanstep · Pull Request #1 · step-security/get-cmake

amanstep · 2025-04-20T10:33:11Z

@Raj-StepSecurity @varunsh-coder Please review this PR and suggest if any changes are to be made

commented out the portion in built-test-tmpl.yml trying to create a new PR for new CMAKE version

Fixed .gitignore to start tracking imoportant js files

Raj-StepSecurity · 2025-04-21T04:57:47Z

src/get-cmake.ts

+
+function forceExit(exitCode: number) {
+  // work around for:
+  //  - https://github.com/lukka/get-cmake/issues/136


remove mention of author

Raj-StepSecurity · 2025-04-21T04:58:14Z

LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2023 StepSecurity


add copyright of author
ie Copyright (c) 2020-2021-2022-2023-2024 Luca Cappa

and keep the stepsecurity copyright as well ?

yes, u can check some other repo for reference

Raj-StepSecurity · 2025-04-21T04:58:46Z

.eslintrc.js

@@ -0,0 +1,23 @@
+// Copyright (c) 2020-2023 Luca Cappa


around 16 mentions of author is present, please remove

Raj-StepSecurity · 2025-04-21T04:59:37Z

.github/workflows/actions_release.yml

+      # script:
+      #   description: "Specify the build script to run"
+      #   required: true
+      #   type: string


remove commented

Raj-StepSecurity · 2025-04-21T06:20:00Z

README.md

+  - [Generate the catalog of CMake releases](#generate-the-catalog-of-cmake-releases)
+  - [Packaging](#packaging)
+  - [Testing](#testing)
+  - [Contributing](#contributing)


remove Contributing, Who is using

Raj-StepSecurity · 2025-04-21T06:25:47Z

README.md

+# License
+All the content in this repository is licensed under the [MIT License](LICENSE).
+
+Copyright (c) 2020-2021-2022-2023-2024 Step Security


removed name of author and other commented code which was not required.

Commented code related to generating catalog and updating new Cmake and ninja version through PR. Commented out code that required persistent secrets

Raj-StepSecurity · 2025-04-21T15:48:46Z

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "libs"]
+	path = libs


this folder does not exist in our code which means its unused, we can safely remove the same. We can just re verify all test cases post that

varunsh-coder · 2025-04-23T05:06:42Z

.github/workflows/actions_release.yml

+      tag:
+        description: "Tag for the release"
+        required: true
+


need to add npm run pack

varunsh-coder · 2025-04-23T05:07:17Z

.github/workflows/audit_package.yml

+  workflow_dispatch:
+    inputs:
+      force:
+        description: "Use --force flag for npm audit fix?"


add npm run pack

varunsh-coder · 2025-04-23T05:10:36Z

.github/workflows/build-test.yml

+    if: false #Disable buildjet's arm based runners usage.
+    uses: ./.github/workflows/build-test-tmpl.yml
+    with:
+      runs-on: "['buildjet-2vcpu-ubuntu-2204-arm']"


use GitHub ARM runner instead of buildjet

varunsh-coder · 2025-04-23T05:12:08Z

.github/workflows/build-test.yml

+    uses: ./.github/workflows/functional-tests-tmpl.yml
+    if: false #Disable buildjet's arm based runners usage.
+    with:
+      runs-on: "['buildjet-2vcpu-ubuntu-2204-arm']"


use GitHub ARM runner

varunsh-coder · 2025-04-23T05:16:55Z

README.md

+### If you want to use  **latest stable** you can use this one-liner:
+```yaml
+  # Option 1: using 'latest' branch, the most recent CMake and ninja are installed.
+    - uses: step-security/get-cmake@latest  # <--= Just this one-liner suffices.


we need to set it to the major version, looks like v4

varunsh-coder · 2025-04-23T05:18:26Z

README.md

+  # Option 2: or you can use the Git 'tag' to select the version, and you can have a one-liner statement,
+  # but note that you can only use one of the existing tags, create a PR to add the tag you need!
+  - name: Get specific version CMake, v3.26.0
+    uses: step-security/get-cmake@v3.26.0     # <- this one-liner is all you need.


use semantic version of the tag that will be released.

varunsh-coder · 2025-04-23T05:19:28Z

README.md

+# License
+All the content in this repository is licensed under the [MIT License](LICENSE).
+
+Copyright (c) 2020-2021-2022-2023-2024-2025 Step Security


Include original author and 2025 for StepSecurity

varunsh-coder · 2025-04-23T05:23:52Z

package.json

+    "@octokit/plugin-paginate-rest": "^5.0.1",
+    "@types/jest": "^29.2.0",
+    "axios": "^1.8.4",
+    "install": "^0.13.0",


can you verify if all the dev dependencies are needed?

I used a tool depcheck which gave the following output

Unused dependencies

@actions/exec

@types/jest

install

octokit

uuid

Unused devDependencies

eslint-plugin-jest

ts-node

varunsh-coder · 2025-04-24T05:57:02Z

Reviewed guarddog findings.

amanstep added 3 commits April 17, 2025 20:07

Initial release

f7db85b

Chore: commented out code not needed right now

0776117

commented out the portion in built-test-tmpl.yml trying to create a new PR for new CMAKE version

fix: Made a change in .gitignore

8a9b620

Fixed .gitignore to start tracking imoportant js files

Raj-StepSecurity reviewed Apr 21, 2025

View reviewed changes

amanstep added 3 commits April 21, 2025 13:29

chore: Removed unnecessary information

9ec17fd

removed name of author and other commented code which was not required.

Removed commented code

20d88e5

chore: Changed workflows to remove unwanted things

3debdca

Commented code related to generating catalog and updating new Cmake and ninja version through PR. Commented out code that required persistent secrets

Raj-StepSecurity reviewed Apr 21, 2025

View reviewed changes

amanstep force-pushed the release branch from 833c59e to 3debdca Compare April 21, 2025 18:56

Removed commented code

d74366e

varunsh-coder reviewed Apr 23, 2025

View reviewed changes

amanstep added 3 commits April 23, 2025 16:09

chore: Updated Readme, and few workflows.

41c62dd

chore: Removed unused dependecies

6e26693

chore: Removed unused .gitmodule file

e099f65

varunsh-coder approved these changes Apr 24, 2025

View reviewed changes

amanstep merged commit 8cb9027 into main Apr 24, 2025
58 of 59 checks passed

		@@ -0,0 +1,21 @@
		The MIT License (MIT)

		Copyright (c) 2023 StepSecurity

Conversation

amanstep commented Apr 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Raj-StepSecurity Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Raj-StepSecurity Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanstep Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

varunsh-coder commented Apr 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Raj-StepSecurity Apr 21, 2025 •

edited

Loading

Raj-StepSecurity Apr 21, 2025 •

edited

Loading

amanstep Apr 23, 2025 •

edited

Loading