Skip to content

fix: Address CodeRabbit review comments from merged PRs#26

Merged
stepandel merged 1 commit intomainfrom
fix/age-pr-review-followups
Feb 9, 2026
Merged

fix: Address CodeRabbit review comments from merged PRs#26
stepandel merged 1 commit intomainfrom
fix/age-pr-review-followups

Conversation

@stepandel
Copy link
Owner

@stepandel stepandel commented Feb 9, 2026

Resolves AGE-36

Follow-up to address outstanding CodeRabbit comments from AGE-30 (PR #18) and AGE-32 (PR #19):

Changes

  • Update @pulumi/hcloud from ^1.0.0 to ^1.32.0 (latest stable)
  • Make allowedSshIps accept pulumi.Input<string[]> for composability with stack outputs

Context

These are minor improvements suggested during code review that weren't addressed before the PRs were merged.

Summary by CodeRabbit

  • Chores
    • Updated Hetzner cloud library to a newer compatible version for improved stability.
    • Enhanced SSH firewall rule construction to better integrate with asynchronous infrastructure operations.

- Update @pulumi/hcloud to ^1.32.0 (latest stable)
- Make allowedSshIps accept pulumi.Input<string[]> for better composability
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

The pull request updates the Hetzner agent implementation to support Pulumi's Input/Output semantics by changing the allowedSshIps parameter type from string[] to pulumi.Input<string[]>. Correspondingly, SSH firewall rule construction is refactored from synchronous to asynchronous handling via pulumi.output().apply(). The @pulumi/hcloud dependency is bumped from ^1.0.0 to ^1.32.0.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json
Bumped @pulumi/hcloud from ^1.0.0 to ^1.32.0.
Hetzner Agent Async Adaptation
src/components/hetzner-agent.ts
Updated allowedSshIps parameter type in HetznerOpenClawAgentArgs from string[] to pulumi.Input<string[]>. Converted SSH firewall rule construction from synchronous conditional logic to asynchronous handling using pulumi.output().apply() to resolve Pulumi Input values before rule computation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 A bumpy hop through Hetzner's hills,
Inputs now flow like morning's rills,
Async rules await their turn,
As dependencies upward churn! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title describes a generic follow-up action but lacks specificity about the actual changes (dependency bump and type signature update). Consider a more specific title like 'Update hcloud dependency and support Pulumi Input for allowedSshIps' that clearly describes the main technical changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/age-pr-review-followups

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@stepandel stepandel merged commit 7b227fa into main Feb 9, 2026
1 check passed
@stepandel stepandel deleted the fix/age-pr-review-followups branch February 9, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant