Skip to content

Default interface methods #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 12, 2022
Merged

Default interface methods #93

merged 19 commits into from
Oct 12, 2022

Conversation

@jadamcrain
Copy link
Member

@jadamcrain jadamcrain commented Oct 11, 2022 •
edited
Loading

This PR adds:

  1. Model representation for default methods of interfaces that can return simple constant values
  2. Back-end implementations for C++ and Java
  3. Back-end implementation for C# that is only enabled if the target framework is set to .NET standard 2.1. The default is 2.0.*

*C# does not support until default implementations until C# 8.0. This version isn't support in .NET standard 2.0.

@jadamcrain
Add the concept of a primitive with a value
d0e3fbf
@jadamcrain
Add the concept of a Duration with a defautl value
382963d
@jadamcrain
add parallel method and types for defining a default implementation r…
58d2680 
…eturn type
@jadamcrain
add From impls for primitives
3ce9cca
@jadamcrain
baseline C++ default method generation
729d5bb
@jadamcrain
add a space between interface methods
8b03eb7
@jadamcrain
add tests for enum and bool
316d918
@jadamcrain
identify and fix a JNI codegen bug where signed integers were not pro…
7227d7f 
…perly being converted from JValues in interface method invocations
@jadamcrain
document default constant return value in c++
46556a3
@jadamcrain
require that the struct initializer be named and parameterless when u…
990c596 
…sing as the default return ovalue of an interface method
@jadamcrain
just emit a warning for C#, b/c we're not prepared to move to C# 8.0 …
41127ac 
…and .NET Standard >= 2.1 yet
@jadamcrain
implement default interface methods in Java backend
396cce8
@jadamcrain
explicitly build ffi/jni for target prior to running ci-script
3cd84b1
@jadamcrain
don't use target var for macos, us cross to build ffi/jni in linux cr…
702c44b 
…oss matrix
@jadamcrain
first step towards making the .NET target framework configurable
5cf731f
@jadamcrain
convert the ci-script to use clap 4.0 with dervice macros
242da64
@jadamcrain
fix the package option
1590100
@jadamcrain
set the .NET target framework in the CI script
21c9977
@jadamcrain
Output default interface methods when the target framework is .NET St…
593dbc9 
…andard 2.1
@jadamcrain jadamcrain merged commit edea250 into main Oct 12, 2022
@jadamcrain jadamcrain deleted the feature/default-interface-methods branch October 12, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jadamcrain