Skip to content

Conversation

@jadamcrain
Copy link
Member

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @jadamcrain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new SECURITY.md file to establish clear guidelines for vulnerability reporting and to detail the project's commitment to supply chain security. It aims to enhance the project's overall security posture by providing transparency on security practices and expectations for users and contributors, aligning with modern security standards and regulatory frameworks like the EU Cyber Resilience Act.

Highlights

  • New Security Policy Document: A comprehensive SECURITY.md file has been added to the repository, outlining the project's security practices and expectations.
  • Vulnerability Reporting Guidelines: The new policy details the process for reporting vulnerabilities privately via GitHub's built-in tooling, along with expected response times for acknowledgements, triage, and resolution.
  • Supply Chain Security Measures: The document describes the project's commitment to supply chain security, including automated nightly audits using cargo audit, pull request checks, regular dependency updates, and the commitment of Cargo.lock for reproducible builds.
  • User Guidance for Security Audits: Instructions are provided for users on how to install and run cargo audit in their own projects to check for vulnerabilities, recommending integration into CI/CD pipelines.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/security-audit.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive SECURITY.md file. The security policy is well-defined, covering vulnerability reporting, response expectations, and supply chain security measures. The document is clear and follows best practices. My review includes one suggestion to improve user experience by providing a more direct link for security advisories.

Comment on lines +36 to +37
- Use the
[GitHub Security Advisories RSS feed](https://github.blog/changelog/2022-10-25-syndicate-github-security-advisories-with-rss/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current link points to a blog post explaining how to find the RSS feed for security advisories. It would be more convenient for users if you provided the direct RSS feed link for this repository.

The direct link is https://github.com/stepfunc/rodbus/security/advisories.rss.

Suggested change
- Use the
[GitHub Security Advisories RSS feed](https://github.blog/changelog/2022-10-25-syndicate-github-security-advisories-with-rss/)
- Use the [GitHub Security Advisories RSS feed for this repository](https://github.com/stepfunc/rodbus/security/advisories.rss)

@jadamcrain jadamcrain merged commit 72537e0 into main Oct 17, 2025
30 checks passed
@jadamcrain jadamcrain deleted the security/policy branch October 17, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants