toml: fix parsing arrays with newlines#2575
Merged
Merged
Conversation
makekryl
commented
May 16, 2026
Comment on lines
+28
to
+46
| // Skip whitespace, newlines and comments | ||
| template <class It, class End> | ||
| inline void skip_ws_newlines_and_comments(It&& it, End end) noexcept | ||
| { | ||
| while (it != end) { | ||
| if (*it == ' ' || *it == '\t' || *it == '\n' || *it == '\r') { | ||
| ++it; | ||
| } | ||
| else if (*it == '#') { | ||
| while (it != end && *it != '\n' && *it != '\r') { | ||
| ++it; | ||
| } | ||
| } | ||
| else { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
It does not seem good (hands are itching to merge with skip_ws_and_comments via a bool template parameter), on the other hand this is a simple way to do that without overcomplicating ¯\_(ツ)_/¯
Contributor
Author
There was a problem hiding this comment.
I'm also not sure whether it would require a separate benchmark like skip_ws_benchmark
Owner
There was a problem hiding this comment.
I think a separate function is good and clear to read. No need to add a separate benchmark for this. At some point I'll work on tighter optimization of TOML, but performance isn't as critical typically for TOML usage.
makekryl
force-pushed
the
toml-arrays-newlines
branch
from
990716b to
ceec28f
Compare
Owner
|
I like this! Thanks for the PR, merging it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.