Skip to content

Conversation

@lianghongzhuo
Copy link
Contributor

As described in #218 this pull request can get all contact points from two objects.

@stepjam
Copy link
Owner

stepjam commented Nov 18, 2020

Hi. Thanks for the PR! So ideally we wrap all sim.py calls in the higher level api (the user shouldn't be calling sim.py). In this case, I guess it belongs in object.py. Once that's done, there needs to be a test for this. See here: https://github.com/stepjam/PyRep/blob/master/tests/test_objects.py

@lianghongzhuo
Copy link
Contributor Author

Yes, I can put it in object.py and add test code

@lianghongzhuo
Copy link
Contributor Author

I found a bug in my pull request, this commit should fix it: cc1b2f8

@stale
Copy link

stale bot commented Feb 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No activity. Will be closed soon. label Feb 19, 2021
@stale stale bot closed this Feb 27, 2021
@lianghongzhuo
Copy link
Contributor Author

Could you review this PR, please? I think contact info is quite important for a robot to learn from the environment.

Copy link
Owner

@stepjam stepjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in checking this. Looks great. Thanks for contributing!

@stepjam stepjam reopened this Mar 14, 2021
@stale stale bot removed the stale No activity. Will be closed soon. label Mar 14, 2021
@stepjam stepjam changed the base branch from master to dev March 14, 2021 15:27
@stepjam stepjam merged commit 93635f5 into stepjam:dev Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants