-
Notifications
You must be signed in to change notification settings - Fork 173
add contact info solve #218 #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi. Thanks for the PR! So ideally we wrap all sim.py calls in the higher level api (the user shouldn't be calling sim.py). In this case, I guess it belongs in object.py. Once that's done, there needs to be a test for this. See here: https://github.com/stepjam/PyRep/blob/master/tests/test_objects.py |
|
Yes, I can put it in object.py and add test code |
|
I found a bug in my pull request, this commit should fix it: cc1b2f8 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Could you review this PR, please? I think contact info is quite important for a robot to learn from the environment. |
stepjam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in checking this. Looks great. Thanks for contributing!
As described in #218 this pull request can get all contact points from two objects.