Skip to content

Conversation

@lianghongzhuo
Copy link
Contributor

@lianghongzhuo lianghongzhuo commented Aug 27, 2021

  1. when set joint positions, first step the environment, then enable dynamics. This will fix the robot model that has both dynamic links and static links.
  2. minor doc string fix for set_joint_position
  3. add a disable_dynamics option in set_to_end function

@stale
Copy link

stale bot commented Nov 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No activity. Will be closed soon. label Nov 1, 2021
@stale stale bot closed this Nov 8, 2021
@lianghongzhuo
Copy link
Contributor Author

Could you review this ? @stepjam

@stepjam
Copy link
Owner

stepjam commented Nov 10, 2021

Yes, sorry for delay! Looks good to me, thanks!!

@stepjam stepjam reopened this Nov 10, 2021
@stale stale bot removed the stale No activity. Will be closed soon. label Nov 10, 2021
@stepjam stepjam merged commit d778d5d into stepjam:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants