Updated user's sync interval and last sync timestamp upon successful … #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manual sync.
Key changes:
- In `SettingsViewModel`, after a successful manual sync:
- Saved the selected sync interval from the UI state to the user's preferences.
- Saved the current timestamp as the last sync time to the user's preferences.
- Updated the UI to display "Just now" as the last sync time.
There was a problem hiding this comment.
Pull Request Overview
Updates the manual sync functionality to properly save user preferences and sync timestamp after a successful sync operation. This ensures the user's selected sync interval and last sync time are persisted to maintain consistency between UI state and stored user data.
- Saves the selected sync interval from UI state to user preferences after successful sync
- Records the current timestamp as the last sync time in user preferences
- Updates UI to show "Just now" as the last sync time and removes outdated comment
|
|
||
| userRepository.saveUser( | ||
| User( | ||
| userName = noteMarkPreferences.getUserName()!!, |
There was a problem hiding this comment.
Using the null assertion operator (!!) on getUserName() could cause a runtime crash if the username is null. Consider using a safe call or providing a default value.
Suggested change
| userName = noteMarkPreferences.getUserName()!!, | |
| userName = noteMarkPreferences.getUserName() ?: "Unknown User", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…manual sync.
Key changes:
SettingsViewModel, after a successful manual sync: