Fixes issue of not showing the sync data time after the sync has happened after a duration of time as passed since the last sync data #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ened after a duration of time as passed since the last sync data
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a date/time calculation issue in the sync status display logic that was preventing the correct sync time from being shown after a certain duration had passed since the last sync.
Key changes:
- Fixed period calculation between sync time and current time
- Simplified datetime formatting by removing redundant padding specification
- Corrected time comparison logic for "Just now" threshold
| val period = syncDateTime.date.minus(currentDateTime.date) | ||
|
|
||
| if(syncDateTime.minute - currentDateTime.minute <= 5) { | ||
| if(period.inWholeMinutes<= 5) { |
There was a problem hiding this comment.
Missing space before the comparison operator. Should be period.inWholeMinutes <= 5 for consistency with Kotlin style guidelines.
Suggested change
| if(period.inWholeMinutes<= 5) { | |
| if (period.inWholeMinutes <= 5) { |
| "Never synced" | ||
| } | ||
| else { | ||
| val syncDateTime = kotlin.time.Instant.fromEpochMilliseconds(this) |
There was a problem hiding this comment.
The period calculation is incorrect. You're subtracting an Instant from an Instant, but syncDateTime is an Instant while you need to compare with current time. This should be val period = currentDateTime - kotlin.time.Instant.fromEpochMilliseconds(this) or convert both to the same type.
Suggested change
| val syncDateTime = kotlin.time.Instant.fromEpochMilliseconds(this) | |
| val syncDateTime = Instant.fromEpochMilliseconds(this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue of not showing the sync data time after the sync has happened after a duration of time as passed since the last sync data