s;roll improvements #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previous code would only explode once, even if it rolled the highest possible number twice in a row - this code will repeatedly explode if it keeps rolling the highest possible number
Contributor
Author
|
|
jwford
added
command
Contributor
Author
|
|
jwford
requested changes
Apr 3, 2020
Member
jwford
left a comment
jwford
left a comment
There was a problem hiding this comment.
Can you add the suggested examples to cover the keeping highest/keeping lowest stuff? Looks great otherwise
Co-Authored-By: Jonathan Ford <jonathanwford156@gmail.com>
Contributor
Author
|
whoops! should be good now |
jwford
requested changes
Apr 3, 2020
Co-Authored-By: Jonathan Ford <jonathanwford156@gmail.com>
BoedJ
suggested changes
Apr 3, 2020
Contributor
BoedJ
left a comment
BoedJ
left a comment
There was a problem hiding this comment.
I'd suggest moving the explanation for the new complex stuff to extendedHelp, and making helpUsage easier for the average person.
(I know very little about dice, so do feel free to correct anything in this suggestion! Just need something along these lines for the help command. Everything else looks good.)
Co-Authored-By: BoedJ <boedj7@gmail.com>
Contributor
Author
|
Not sure why it still says blocked on changes requested when I already did them. But it should be good to go now! |
jwford
approved these changes
Apr 3, 2020
BoedJ
approved these changes
Apr 3, 2020
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.
s;roll 1d8|4d6Roll multiple dice at onces;roll 2d20k1Roll multiple dice, keep highest ns;roll 2d20kl1Roll multiple dice, keep lowest ns;roll d20Infer the dice count to be 1 if omittedAlso fixes exploding dice: the current code only explodes once even if the max value is rolled twice. The proposed code will keep exploding repeatedly if possible.