Add support for corporate http(s) proxies, via request `proxy` option. #42

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@asnowfix

This is something that is (was) missing from node-jira when trying to use *.atlassian.net from behind a corporate proxy.

@robertlevy

This comment has been minimized.

Show comment Hide comment
@robertlevy

robertlevy Jun 6, 2014

I'd like this feature as well but it could be implemented much easier by simply tweaking the ctor:

this.request = require('request').defaults({proxy: proxy})

There's no need to set the option on a per-api basis since you're either going to want to send everything through the proxy or nothing through the proxy.

I'd like this feature as well but it could be implemented much easier by simply tweaking the ctor:

this.request = require('request').defaults({proxy: proxy})

There's no need to set the option on a per-api basis since you're either going to want to send everything through the proxy or nothing through the proxy.

@asnowfix

This comment has been minimized.

Show comment Hide comment
@asnowfix

asnowfix Jun 6, 2014

@robertlevy nice tip.

asnowfix commented Jun 6, 2014

@robertlevy nice tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment