fix: skip Docker Hub network calls when Dolt image not cached#2300
Merged
steveyegge merged 1 commit intosteveyegge:mainfrom Mar 3, 2026
Merged
fix: skip Docker Hub network calls when Dolt image not cached#2300steveyegge merged 1 commit intosteveyegge:mainfrom
steveyegge merged 1 commit intosteveyegge:mainfrom
Conversation
Check for locally cached Docker image before calling dolt.Run(), which contacts Docker Hub even when the image is already present. Tests now skip with a helpful pull command when the exact image:tag is missing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing in favor of c2888b1 which takes a cleaner approach — merging the image cache check into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dolt.Run(), which contacts Docker Hub even when the image is already presentdocker pullcommand when the exact image:tag is missingStartTestDoltServer,StartIsolatedDoltContainer,EnsureDoltContainerForTestMain,RequireDoltContainerFixes #2277
Behavior matrix
docker pull dolthub/dolt-sql-server:1.43.0"docker pull dolthub/dolt-sql-server:1.43.0"Rows 2 and 4 produce the same outcome —
docker image inspectchecks the exact tag, so a stale cached version won't match.Test plan
go vet ./internal/testutil/passesgo test ./cmd/bd/... -count=1passes (pre-existingTestCheckTestPollution_NoTestIssuesfailure unrelated)🤖 Generated with Claude Code