Fix taint-related arithmetic errors in MoneyFrame (#96)#97
Merged
stevin05 merged 1 commit intostevin05:mainfrom Mar 13, 2026
Merged
Fix taint-related arithmetic errors in MoneyFrame (#96)#97stevin05 merged 1 commit intostevin05:mainfrom
stevin05 merged 1 commit intostevin05:mainfrom
Conversation
- Wrap GameTooltip:SetRecipeResultItem calls in securecall to ensure update logic runs in a secure context. - Use anonymous frame for the toggle button in ProfessionsFrame to avoid taint propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the 'tainted by CraftScan' error that causes an arithmetic crash in MoneyFrame.lua.
Fixes #96