Run tidy_images in CI workflows#87
Merged
Merged
Conversation
We should run the tidy_image role in CI workflow to test it works. We do this by not running the reboot task as we cannot reboot localhost
khalford
force-pushed
the
test_tidy_image
branch
from
8372b69 to
d978850
Compare
khalford
force-pushed
the
test_tidy_image
branch
from
d4a9dad to
3118eda
Compare
Locales are not present on the containers we use to test the playbooks. Although these usually come by default on our OS images we should add them to make sure they are.
khalford
force-pushed
the
test_tidy_image
branch
from
3118eda to
7a1dd21
Compare
khalford
force-pushed
the
test_tidy_image
branch
2 times, most recently
from
ef3d5e4 to
85cdcba
Compare
Add a when to this block of tasks to not run on containers as they do not use systemd which localectl relies on and wazuh.
khalford
force-pushed
the
test_tidy_image
branch
from
85cdcba to
1e9ea8c
Compare
Removing sudo fron tasks as it is not installed on containers. We should rely on become for privilege escalation
Add ignore errors to this task as clearing the file is the same as it not existing.
Add trace to the bash scripts so we can debug better.
We don't need to run the update keys script in tidy role as we already copy the keys and set up a cron job in vm_baseline
Add a GitHub PAT to increase the rate limit threshold for doing packer init as it makes requests to github.
khalford
force-pushed
the
test_tidy_image
branch
from
d0c74c0 to
d8b4803
Compare
DavidFair
approved these changes
Dec 4, 2025
jose-caballero
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should run the tidy_image role in CI workflow to test it works.
Includes fixes for all the tasks that don't and won't work on containers