-
Notifications
You must be signed in to change notification settings - Fork 32
Initial documentation #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…inally created by Pearu
|
Just a note to say that I used sphinx-quickstart to re-generate the Makefile and conf.py files for the documentation which is why there are so many differences. |
rupertford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I don't like the documentation as it is. It is simply a list of all the classes and methods and their interfaces which is not going to be much use to most people.
What I think would be useful in the first instance is a simple introduction on how to parse a fortran code using fparser ...
-
a quick overview section (which you pretty much have)
-
a section which shows how to parse a program, output the code again, see the internal structure and walk the tree, all using the "default" parser. Most of this can be generated automatically from the doc strings of the appropriate classes, it just needs to be pulled together with some additional text.
-
A section repeating the above for the f2003 parser.
-
Optionally an appendix with all the current autogenerated API stuff.
…g. Prepare to add section on Fortran2003 module
|
I've removed all auto-generated content and re-structured the document slightly to give the Fortran66-90 and Fortran2003 parsers their own sections. The latter is rather sparse as I have to confess I got habakkuk working on a trial-and-error basis and don't have a deep understanding of the workings of the parser. |
|
It's better now and I think it's good enough as an initial document so am approving. However, for the record, I think it still reads mostly like a reference guide as it is based around the structure of the python packages. I think would be improved by starting from the perspective of what users would want to do i.e. how to parse fortran code (as a section), then how to iterate over the tree (as a section). Some minor points you can ignore if you want ... I don't see why we include information about CHAR_BIT in the api.py file as it is not referenced or explained anywhere. I think the names of the sections for the two parsers should be made consistent. I think renaming the first "Parser for Fortran66..." should be renamed to "Fortran66... parser". |
I've incorporated Pearu's old documentation in the new structure. I've also added extra auto-generated documentation using sphinx.