Update Node.js version requirements for release automation#143
Merged
Conversation
- Update `Update-NovaModuleVersion -ContinuousIntegration` to fallback to a patch bump when `HEAD` matches the latest tag - Fix PSGallery publishing on fresh CI runners by bootstrapping the PSResourceGet repository store - Add `Get-PSResourceRepositoryStoreDirectory` and `Initialize-PSGalleryRepository` functions
There was a problem hiding this comment.
Gates Passed
6 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update-NovaModuleVersion -ContinuousIntegrationnow falls back to a patch bump whenHEADalready matches thelatest tag, so the publish workflow can prepare the next prerelease version without requiring an extra commit first.
Publish-PSResource, and the publish script now fails fast on publish errors.mainrelease flow can legitimately hitCannot bump version because there are no commits since the latest tag.after a release, and that should remain a normal error outside CI while stillallowing the CI prerelease-seeding path to continue. It was also needed because fresh GitHub Actions runners can miss
PSResourceRepository.xml, which caused the PSGallery publish step to fail before the repository store existed.#140.Affected area
novaCLI or command routingproject.jsonhandlingREADME.md,CONTRIBUTING.md, repository workflow docs)docs/*.html)docs/NovaModuleTools/en-US/*.md)src/resources/example/package.json, workflow dependencies, release tooling)Review guidance
src/private/release/GetNovaVersionLabelForBump.ps1together withsrc/private/release/GetNovaVersionUpdateWorkflowContext.ps1for the CI-only tagged-head bump fallback.scripts/release/Publish-ToPSGallery.ps1,scripts/release/SemanticReleaseSupport.ps1, andscripts/release/support/Initialize-PSGalleryRepository.ps1for the semantic-release PSGallery bootstrap andfail-fast behavior.
src/private/release/GetNovaVersionLabelForBump.ps1src/private/release/GetNovaVersionUpdateWorkflowContext.ps1scripts/release/Publish-ToPSGallery.ps1scripts/release/SemanticReleaseSupport.ps1scripts/release/support/Get-PSResourceRepositoryStoreDirectory.ps1scripts/release/support/Initialize-PSGalleryRepository.ps1tests/NovaCommandModel.BumpAndCli.Tests.ps1tests/CoverageGaps.ReleaseInternals.Tests.ps1tests/SemanticRelease.Tests.ps1README.mdCHANGELOG.mdrequested.
developbranch path, so there is now someduplication between workflow setup and the publish script hardening.
Validation
Invoke-NovaBuildTest-NovaBuild./scripts/build/Invoke-ScriptAnalyzerCI.ps1./scripts/build/ci/Invoke-NovaModuleToolsCI.ps1% nova build,% nova test,% nova merge,% nova deploy,% nova publish,% nova release,% nova update,% nova notification, or% nova initas relevant)Validation notes:
Documentation and release follow-up
README.mdreviewed and updated if contributor workflow, architecture, CI, release, or automation changedCONTRIBUTING.mdreviewed and updated if contribution expectations or review guidance changedCHANGELOG.mdreviewed and updated if the change matters to users, maintainers, or contributorsdocs/NovaModuleTools/en-US/help updated if a public command or CLI behavior changeddocs/*.htmlupdated if end-user workflows or examples changedsrc/resources/example/reviewed and updated if the real-world project layout, package model, or upload workflowchanged
Maintainability, compatibility, and risk
Risk, rollout, or rollback notes:
Important
Do not use a public pull request to disclose a vulnerability before coordinated handling.
Use the private reporting path in
SECURITY.mdfor new security issues.