Created centralized unwrapping messenger exceptions#25
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR introduces ChangesException Unwrapping Refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/Unit/Exception/WrappedExceptionUnwrapperTest.php (1)
40-97: ⚡ Quick winConsolidate similar unwrap cases with a data provider.
The unwrap scenario tests are strong, but these closely related cases can be merged into one parameterized test to reduce duplication and align with the test standard.
As per coding guidelines, "Use #[DataProvider] for multiple similar scenarios."♻️ Suggested refactor sketch
+#[DataProvider('wrappedExceptionProvider')] +public function testUnwrapsWrappedExceptions(Throwable $wrapper, Throwable $expected): void +{ + // Arrange + $unwrapper = new WrappedExceptionUnwrapper(); + + // Act + $result = $unwrapper->unwrap($wrapper); + + // Assert + self::assertSame($expected, $result); +} + +/** + * `@return` iterable<string, array{0: Throwable, 1: Throwable}> + */ +public static function wrappedExceptionProvider(): iterable +{ + $singleCause = new RuntimeException('the real cause'); + yield 'handler failed single cause' => [ + new HandlerFailedException(new Envelope(new stdClass()), [$singleCause]), + $singleCause, + ]; + + $first = new RuntimeException('first handler'); + $second = new LogicException('second handler'); + yield 'handler failed multiple causes returns first' => [ + new HandlerFailedException(new Envelope(new stdClass()), [$first, $second]), + $first, + ]; + + $root = new RuntimeException('root'); + $inner = new HandlerFailedException(new Envelope(new stdClass()), [$root]); + yield 'nested handler failed recursive unwrap' => [ + new HandlerFailedException(new Envelope(new stdClass()), [$inner]), + $root, + ]; +}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/Unit/Exception/WrappedExceptionUnwrapperTest.php` around lines 40 - 97, Replace the four separate tests that exercise similar unwrap logic with a single parameterized test using PHPUnit's #[DataProvider] attribute: create a data provider method (e.g., provideWrappedExceptionScenarios) that yields arrays of [wrappedExceptionInstance, expectedCause] covering the cases in the existing tests (single HandlerFailedException with one cause, HandlerFailedException with multiple causes returning the first, nested HandlerFailedException returning the inner root cause, and DelayedMessageHandlingException with a single cause), then implement one test method (e.g., testUnwrapsWrappedExceptionScenarios) that accepts the two parameters, calls WrappedExceptionUnwrapper::unwrap on the provided exception and asserts same() against the expected cause; reference class/constructor symbols HandlerFailedException, DelayedMessageHandlingException, Envelope and WrappedExceptionUnwrapper when building the provider cases.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/Unit/Exception/WrappedExceptionUnwrapperTest.php`:
- Around line 40-97: Replace the four separate tests that exercise similar
unwrap logic with a single parameterized test using PHPUnit's #[DataProvider]
attribute: create a data provider method (e.g.,
provideWrappedExceptionScenarios) that yields arrays of
[wrappedExceptionInstance, expectedCause] covering the cases in the existing
tests (single HandlerFailedException with one cause, HandlerFailedException with
multiple causes returning the first, nested HandlerFailedException returning the
inner root cause, and DelayedMessageHandlingException with a single cause), then
implement one test method (e.g., testUnwrapsWrappedExceptionScenarios) that
accepts the two parameters, calls WrappedExceptionUnwrapper::unwrap on the
provided exception and asserts same() against the expected cause; reference
class/constructor symbols HandlerFailedException,
DelayedMessageHandlingException, Envelope and WrappedExceptionUnwrapper when
building the provider cases.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d2374ce2-c659-48d4-863a-376674b95202
📒 Files selected for processing (8)
config/controller.phpconfig/subscribers.phpsrc/Controller/CommandController.phpsrc/EventSubscriber/ApiExceptionSubscriber.phpsrc/Exception/WrappedExceptionUnwrapper.phptests/Unit/Controller/CommandControllerTest.phptests/Unit/EventSubscriber/ApiExceptionSubscriberTest.phptests/Unit/Exception/WrappedExceptionUnwrapperTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Tests