Replace additional info in server response with async requests from client#252
Merged
Merged
Conversation
Returned data becomes more friendly to REST API calls, and responses may be marginally faster when the server has a lot of files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server is currently gathering and returning information about the file system in several endpoints, which may be unnecessary and bloat the response if the calls are being made through an API. This also implies duplicate code that increases the chance of mistakes if the functions that gather file system information are altered.
This PR ensures that the server avoids performing unnecessary work for API requests, and the client must rely on calls to
/filesand/infoto get updated information. In the web application, this means making these calls asynchronously after receiving responses from the endpoints that previously returned file system information.